Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2871)

Issue 12801044: Faster container creation via lxc-clone

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years ago by sidnei.da.silva
Modified:
5 years, 9 months ago
Reviewers:
william.reade, wallyworld, fwereade, mp+180445
Visibility:
Public.

Description

Faster container creation via lxc-clone Use the newer Clone arguments in golxc to request a snapshot container with a specific backing store, create base template for selected distro if one doesn't exist yet. https://code.launchpad.net/~sidnei/juju-core/lxc-clone-with-overlayfs/+merge/180445 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -32 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M container/lxc/lxc.go View 3 chunks +51 lines, -31 lines 2 comments Download
M container/lxc/mock/mock-lxc.go View 1 chunk +1 line, -1 line 0 comments Download
M upstart/upstart.go View 1 chunk +1 line, -0 lines 0 comments Download
M upstart/upstart_test.go View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
wallyworld
Looks like a nice change. I'd like to see some tests to ensure the new ...
5 years, 9 months ago (2013-11-04 02:51:34 UTC) #1
fwereade
Yeah, definitely needs tests, otherwise very nice. I guess the notify problems with overlayfs aren't ...
5 years, 9 months ago (2013-11-06 12:28:44 UTC) #2
sidnei.da.silva
On 2013/11/06 12:28:44, fwereade wrote: > Yeah, definitely needs tests, otherwise very nice. I guess ...
5 years, 9 months ago (2013-11-06 12:40:23 UTC) #3
sidnei.da.silva
5 years, 9 months ago (2013-11-06 12:40:48 UTC) #4
william.reade
5 years, 9 months ago (2013-11-18 10:48:05 UTC) #5
I still don't see tests for container/lxc -- surely with these new params we
should be testing at least that we get what's expected?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b