code review 12798045: net: wait longer before failing TestVariousDeadlines4Pr...

net: wait longer before failing TestVariousDeadlines4Proc on windows

This is an attempt to make our slow
windows-386 builder more reliable.

[brainman, 2013-08-23 05:04:45]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[dave_cheney.net, 2013-08-23 05:06:39]

LGTM. Worth a try.

On Fri, Aug 23, 2013 at 3:04 PM,  <alex.brainman@gmail.com> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> net: wait longer before failing TestVariousDeadlines4Proc on windows
>
> This is an attempt to make our slow
> windows-386 builder more reliable.
>
> Please review this at https://codereview.appspot.com/12798045/
>
> Affected files:
>   M src/pkg/net/timeout_test.go
>
>
> Index: src/pkg/net/timeout_test.go
> ===================================================================
> --- a/src/pkg/net/timeout_test.go
> +++ b/src/pkg/net/timeout_test.go
> @@ -496,7 +496,10 @@
>                                 clientc <- copyRes{n, err, d}
>                         }()
>
> -                       const tooLong = 2000 * time.Millisecond
> +                       tooLong := 2 * time.Second
> +                       if runtime.GOOS == "windows" {
> +                               tooLong = 5 * time.Second
> +                       }
>                         select {
>                         case res := <-clientc:
>                                 if isTimeout(res.err) {
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

[brainman, 2013-08-23 05:07:49]

*** Submitted as https://code.google.com/p/go/source/detail?r=46ad4e3bfcf5 ***

net: wait longer before failing TestVariousDeadlines4Proc on windows

This is an attempt to make our slow
windows-386 builder more reliable.

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/12798045