Issue 12798043: code review 12798043: runtime: change textflags from numbers to symbols

Issue 12798043: code review 12798043: runtime: change textflags from numbers to symbols (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by khr

Modified:
11 years, 10 months ago

Reviewers:
bradfitz

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

runtime: change textflags from numbers to symbols

Patch Set 1 #

Patch Set 2 : diff -r 7064d3304d65 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r 7064d3304d65 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 4 : diff -r 7064d3304d65 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 5 : diff -r 7064d3304d65 https://khr%40golang.org@code.google.com/p/go/ #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -119 lines)			Patch
M	src/pkg/runtime/alg.c	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/atomic_386.c	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/atomic_amd64.c	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/atomic_arm.c	View	1	11 chunks	+13 lines, -12 lines	0 comments	Download
M	src/pkg/runtime/cgocall.c	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/chan.c	View	1	16 chunks	+16 lines, -15 lines	0 comments	Download
M	src/pkg/runtime/hashmap.c	View	1	7 chunks	+7 lines, -6 lines	0 comments	Download
M	src/pkg/runtime/hashmap_fast.c	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/iface.c	View	1	8 chunks	+8 lines, -7 lines	0 comments	Download
M	src/pkg/runtime/lock_futex.c	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/lock_sema.c	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/malloc.goc	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/noasm_arm.goc	View	1 2 3	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/os_darwin.c	View	1	4 chunks	+4 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/os_freebsd.c	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/os_freebsd_arm.c	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/os_linux.c	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/os_linux_386.c	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/os_linux_arm.c	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/os_netbsd.c	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/os_netbsd_arm.c	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/os_openbsd.c	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/os_plan9.c	View	1	4 chunks	+5 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/os_windows.c	View	1	5 chunks	+6 lines, -5 lines	0 comments	Download
M	src/pkg/runtime/panic.c	View	1	4 chunks	+4 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/print.c	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/proc.c	View	1	11 chunks	+11 lines, -10 lines	0 comments	Download
M	src/pkg/runtime/race.c	View	1	11 chunks	+11 lines, -10 lines	0 comments	Download
M	src/pkg/runtime/runtime.c	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/sigqueue.goc	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/slice.c	View	1	5 chunks	+5 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/softfloat_arm.c	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/string.goc	View	1 2 3	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/time_plan9_386.c	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/vlrt_386.c	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/pkg/runtime/vlrt_arm.c	View	1	7 chunks	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

khr

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/

11 years, 10 months ago (2013-08-12 19:56:56 UTC) #1

khr

11 years, 10 months ago (2013-08-12 20:47:24 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=745f029d8e08 ***

runtime: change textflags from numbers to symbols

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12798043

Expand All Messages | Collapse All Messages