Fixes support for loading config from file.

Fixes support for loading config from file.

The config file handling code was copied to the inspector, but the tests
weren't. Most of this branch is adding the tests from the old to the new.

- The two main bugs were that the variable name was called fileContent vs
configFileContent.
- The other was the deploy call looking on this.configFileContent vs on the
viewletManager where the content is kept.
- Small change to the onFileLoad to make testing easier. The UI is updated now
without having to fake it or to mock up handleFileChange in odd ways.
- Also did some small tweaks to alphabetize the var names and such in the
tests to make it easier to see what vars there are and find out if something
is global (in the test scope) or not.

https://code.launchpad.net/~rharding/juju-gui/ghost-config-upload/+merge/180176

(do not edit description out of merge proposal)

[rharding, 2013-08-14 15:48:56]

Please take a look.

[jeff.pihach, 2013-08-14 15:56:07]

This is looking good thanks for the fix and the tests!

Couple small things and a little expansion on the tests req'd

https://codereview.appspot.com/12797046/diff/1/app/views/charm-panel.js
File app/views/charm-panel.js (right):

https://codereview.appspot.com/12797046/diff/1/app/views/charm-panel.js#newco...
app/views/charm-panel.js:319: '.zonfig-file-upload-widget': {change:
'onFileChange'},
zomg it's a zonfig!

https://codereview.appspot.com/12797046/diff/1/test/test_ghost_inspector.js
File test/test_ghost_inspector.js (right):

https://codereview.appspot.com/12797046/diff/1/test/test_ghost_inspector.js#n...
test/test_ghost_inspector.js:216: it('must remove configuration data when the
button is pressed', function() {
this test name isn't really representative of what's going on.

https://codereview.appspot.com/12797046/diff/1/test/test_ghost_inspector.js#n...
test/test_ghost_inspector.js:265: assert.equal(received_config_raw, config_raw);
Should add some tests here to make sure that the model in the db has the proper
data. and that it was sent to the env.

[matthew.scott, 2013-08-14 15:56:53]

LGTM once Jeff's happy.  Thanks for the tests!

[rharding, 2013-08-14 15:57:00]

Please take a look.

https://codereview.appspot.com/12797046/diff/1/app/views/charm-panel.js
File app/views/charm-panel.js (right):

https://codereview.appspot.com/12797046/diff/1/app/views/charm-panel.js#newco...
app/views/charm-panel.js:319: '.zonfig-file-upload-widget': {change:
'onFileChange'},
ok...so this wasn't meant to be there...

[jeff.pihach, 2013-08-14 16:18:21]

LGTM

[rharding, 2013-08-15 00:47:49]

*** Submitted:

Fixes support for loading config from file.

The config file handling code was copied to the inspector, but the tests
weren't. Most of this branch is adding the tests from the old to the new.

- The two main bugs were that the variable name was called fileContent vs
configFileContent.
- The other was the deploy call looking on this.configFileContent vs on the
viewletManager where the content is kept.
- Small change to the onFileLoad to make testing easier. The UI is updated now
without having to fake it or to mock up handleFileChange in odd ways.
- Also did some small tweaks to alphabetize the var names and such in the
tests to make it easier to see what vars there are and find out if something
is global (in the test scope) or not.

R=jeff.pihach, matthew.scott
CC=
https://codereview.appspot.com/12797046