Issue 12797045: code review 12797045: cmd/gc: move flow graph into portable opt

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12797045: code review 12797045: cmd/gc: move flow graph into portable opt (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by rsc

Modified:
11 years, 10 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

cmd/gc: move flow graph into portable opt Now there's only one copy of the flow graph construction and dominator computation, and different optimizations can attach different annotations to the instructions.

Patch Set 1 #

Patch Set 2 : diff -r 48e6614d4cdf https://code.google.com/p/go/ #

Patch Set 3 : diff -r 73e48985674b https://code.google.com/p/go/ #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+970 lines, -1507 lines)			Patch
M	src/cmd/5g/opt.h	View	1 2	4 chunks	+4 lines, -30 lines	0 comments	Download
M	src/cmd/5g/peep.c	View	1 2	43 chunks	+123 lines, -172 lines	0 comments	Download
M	src/cmd/5g/reg.c	View	1	32 chunks	+140 lines, -363 lines	0 comments	Download
M	src/cmd/6g/opt.h	View	1 2	5 chunks	+5 lines, -35 lines	0 comments	Download
M	src/cmd/6g/peep.c	View	1 2	25 chunks	+72 lines, -122 lines	0 comments	Download
M	src/cmd/6g/reg.c	View	1	29 chunks	+125 lines, -333 lines	0 comments	Download
M	src/cmd/8g/opt.h	View	1 2	3 chunks	+5 lines, -17 lines	0 comments	Download
M	src/cmd/8g/peep.c	View	1 2	19 chunks	+56 lines, -104 lines	0 comments	Download
M	src/cmd/8g/reg.c	View	1	27 chunks	+125 lines, -331 lines	0 comments	Download
M	src/cmd/gc/popt.h	View	1 2	1 chunk	+34 lines, -0 lines	0 comments	Download
M	src/cmd/gc/popt.c	View	1 2	1 chunk	+281 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 10 months ago (2013-08-13 02:02:08 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=530b2d6e0b38 *** cmd/gc: move flow graph into portable opt Now there's only ...

11 years, 10 months ago (2013-08-13 02:02:14 UTC) #2

ken3

11 years, 10 months ago (2013-08-13 11:02:18 UTC) #3

Message was sent while issue was closed.

On 2013/08/13 02:02:14, rsc wrote:
> *** Submitted as https://code.google.com/p/go/source/detail?r=530b2d6e0b38 ***
> 
> cmd/gc: move flow graph into portable opt
> 
> Now there's only one copy of the flow graph construction
> and dominator computation, and different optimizations
> can attach different annotations to the instructions.
> 
> R=ken2
> CC=golang-dev
> https://codereview.appspot.com/12797045

mia culpa. this should have
been done for the 2nd compiler.

lgtm

Expand All Messages | Collapse All Messages