Issue 12795046: Fixes expected models in destroy

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12795046: Fixes expected models in destroy

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by j.c.sackett

Modified:
10 years, 8 months ago

Reviewers:
rharding, mp+180351, jeff.pihach

Visibility:
Public.

Description

Fixes expected models in destroy As part of the fallout from the great model unification of '13, destroying ghost services in the service inspector stopped working. This was because it was expecting `charm` when `browser-charm` is actually passed. https://code.launchpad.net/~jcsackett/juju-gui/service-destroy-browsercharm/+merge/180351 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fixes expected models in destroy #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	app/views/inspector.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jeff.pihach

LGTM Thank you very much for getting on this right away!

10 years, 8 months ago (2013-08-15 14:27:23 UTC) #3

j.c.sackett

10 years, 8 months ago (2013-08-15 14:38:29 UTC) #4

*** Submitted:

Fixes expected models in destroy

As part of the fallout from the great model unification of '13, destroying ghost
services in the service inspector stopped working. This was because it was
expecting `charm` when `browser-charm` is actually passed.

R=rharding, jeff.pihach
CC=
https://codereview.appspot.com/12795046

Expand All Messages | Collapse All Messages