Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(523)

Issue 12791043: Adjust the onLogin event to keep QS and hashes.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by rharding
Modified:
11 years, 11 months ago
Reviewers:
bac, mp+179765, jeff.pihach
Visibility:
Public.

Description

Adjust the onLogin event to keep QS and hashes. - Fixes #1199392 - The login process wants to get you back to your original url. - It currently only keeps the pathname part of the url and not the query string or url hash - This causes the onLogin to change the url and force a re-dispatch. - This changes the process to keep everything after the hostname by building the url from pathname + search + hash. - There's no new tests because tests would require window.location mangling. Please verify that you get expected behavior for the url fullscreen/search/precise/apache2-10/?series=precise&text=apache&type=approved#bws-readme This breaks in jujucharms.com/comingsoon. https://code.launchpad.net/~rharding/juju-gui/querystring-1199392/+merge/179765 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Adjust the onLogin event to keep QS and hashes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 4 chunks +22 lines, -3 lines 0 comments Download

Messages

Total messages: 4
rharding
Please take a look.
11 years, 11 months ago (2013-08-12 18:20:56 UTC) #1
bac
LGTM code and QA
11 years, 11 months ago (2013-08-12 18:35:11 UTC) #2
jeff.pihach
LGTM - I would like this broken out into a method which can be mocked ...
11 years, 11 months ago (2013-08-12 19:11:51 UTC) #3
rharding
11 years, 11 months ago (2013-08-12 19:19:58 UTC) #4
*** Submitted:

Adjust the onLogin event to keep QS and hashes.

- Fixes #1199392
- The login process wants to get you back to your original url.
- It currently only keeps the pathname part of the url and not the query
string or url hash
- This causes the onLogin to change the url and force a re-dispatch.
- This changes the process to keep everything after the hostname by building
the url from pathname + search + hash.
- There's no new tests because tests would require window.location mangling.
Please verify that you get expected behavior for the url
fullscreen/search/precise/apache2-10/?series=precise&text=apache&type=approved#bws-readme

This breaks in jujucharms.com/comingsoon.

R=bac, jeff.pihach
CC=
https://codereview.appspot.com/12791043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b