code review 12789043: cmd/gc: support for "portable" optimization logic

cmd/gc: support for "portable" optimization logic

Code in gc/popt.c is compiled as part of 5g, 6g, and 8g,
meaning it can use arch-specific headers but there's
just one copy of the code.

This is the same arrangement we use for the portable
code generation logic in gc/pgen.c.

Move fixjmp and noreturn there to get the ball rolling.

[rsc, 2013-08-12 23:13:59]

Hello ken2 (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[rsc, 2013-08-12 23:14:06]

*** Submitted as https://code.google.com/p/go/source/detail?r=82edc0e0cc18 ***

cmd/gc: support for "portable" optimization logic

Code in gc/popt.c is compiled as part of 5g, 6g, and 8g,
meaning it can use arch-specific headers but there's
just one copy of the code.

This is the same arrangement we use for the portable
code generation logic in gc/pgen.c.

Move fixjmp and noreturn there to get the ball rolling.

R=ken2
CC=golang-dev
https://codereview.appspot.com/12789043

[bradfitz, 2013-08-12 23:17:18]

Nice.




On Mon, Aug 12, 2013 at 4:13 PM, <rsc@golang.org> wrote:

> Reviewers: ken2,
>
> Message:
> Hello ken2 (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> cmd/gc: support for "portable" optimization logic
>
> Code in gc/popt.c is compiled as part of 5g, 6g, and 8g,
> meaning it can use arch-specific headers but there's
> just one copy of the code.
>
> This is the same arrangement we use for the portable
> code generation logic in gc/pgen.c.
>
> Move fixjmp and noreturn there to get the ball rolling.
>
> Please review this at
https://codereview.appspot.**com/12789043/<https://codereview.appspot.com/127...
>
> Affected files:
>   M src/cmd/5g/gg.h
>   M src/cmd/5g/opt.h
>   M src/cmd/5g/peep.c
>   M src/cmd/5g/prog.c
>   M src/cmd/5g/reg.c
>   M src/cmd/6g/gg.h
>   M src/cmd/6g/opt.h
>   M src/cmd/6g/peep.c
>   M src/cmd/6g/prog.c
>   M src/cmd/6g/reg.c
>   M src/cmd/8g/gg.h
>   M src/cmd/8g/opt.h
>   M src/cmd/8g/peep.c
>   M src/cmd/8g/prog.c
>   M src/cmd/8g/reg.c
>   M src/cmd/dist/build.c
>   M src/cmd/gc/pgen.c
>   A src/cmd/gc/popt.c
>   A src/cmd/gc/popt.h
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[ken3, 2013-08-13 10:43:05]

On 2013/08/12 23:17:18, bradfitz wrote:
> Nice.
> 
> 
> 
> 
> On Mon, Aug 12, 2013 at 4:13 PM, <mailto:rsc@golang.org> wrote:
> 
> > Reviewers: ken2,
> >
> > Message:
> > Hello ken2 (cc: mailto:golang-dev@googlegroups.com),
> >
> > I'd like you to review this change to
> > https://code.google.com/p/go/
> >
> >
> > Description:
> > cmd/gc: support for "portable" optimization logic
> >
> > Code in gc/popt.c is compiled as part of 5g, 6g, and 8g,
> > meaning it can use arch-specific headers but there's
> > just one copy of the code.
> >
> > This is the same arrangement we use for the portable
> > code generation logic in gc/pgen.c.
> >
> > Move fixjmp and noreturn there to get the ball rolling.
> >
> > Please review this at
>
https://codereview.appspot.**com/12789043/%3Chttps://codereview.appspot.com/1...>
> >
> > Affected files:
> >   M src/cmd/5g/gg.h
> >   M src/cmd/5g/opt.h
> >   M src/cmd/5g/peep.c
> >   M src/cmd/5g/prog.c
> >   M src/cmd/5g/reg.c
> >   M src/cmd/6g/gg.h
> >   M src/cmd/6g/opt.h
> >   M src/cmd/6g/peep.c
> >   M src/cmd/6g/prog.c
> >   M src/cmd/6g/reg.c
> >   M src/cmd/8g/gg.h
> >   M src/cmd/8g/opt.h
> >   M src/cmd/8g/peep.c
> >   M src/cmd/8g/prog.c
> >   M src/cmd/8g/reg.c
> >   M src/cmd/dist/build.c
> >   M src/cmd/gc/pgen.c
> >   A src/cmd/gc/popt.c
> >   A src/cmd/gc/popt.h
> >
> >
> > --
> >
> > ---You received this message because you are subscribed to the Google
> > Groups "golang-dev" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to
>
mailto:golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegroups.com>
> > .
> > For more options, visit
>
https://groups.google.com/**groups/opt_out%3Chttps://groups.google.com/groups...>
> > .
> >
> >
> >

lgtm