code review 12787044: runtime/pprof: test netbsd and openbsd again

runtime/pprof: test netbsd and openbsd again

Maybe these will work now.

[rsc, 2013-08-13 16:19:34]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[rsc, 2013-08-13 16:19:56]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[dvyukov, 2013-08-13 16:27:13]

On 2013/08/13 16:19:56, rsc wrote:
> Hello mailto:golang-dev@googlegroups.com (cc:
mailto:golang-dev@googlegroups.com),
> 
> Please take another look.

LGTM
let's see

[bradfitz, 2013-08-13 16:31:22]

What changed that these might work now?



On Tue, Aug 13, 2013 at 9:19 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> runtime/pprof: test netbsd and openbsd again
>
> Maybe these will work now.
>
> Please review this at
https://codereview.appspot.**com/12787044/<https://codereview.appspot.com/127...
>
> Affected files:
>   M src/pkg/runtime/pprof/pprof.go
>   M src/pkg/runtime/pprof/pprof_**test.go
>
>
> Index: src/pkg/runtime/pprof/pprof.go
> ==============================**==============================**=======
> --- a/src/pkg/runtime/pprof/pprof.**go
> +++ b/src/pkg/runtime/pprof/pprof.**go
> @@ -20,7 +20,7 @@
>         "text/tabwriter"
>  )
>
> -// BUG(rsc): Profiles are incomplete and inaccuate on NetBSD, OpenBSD,
> and OS X.
> +// BUG(rsc): Profiles are incomplete and inaccuate on OS X.
>  // See http://golang.org/issue/6047 for details.
>
>  // A Profile is a collection of stack traces showing the call sequences
> Index: src/pkg/runtime/pprof/pprof_**test.go
> ==============================**==============================**=======
> --- a/src/pkg/runtime/pprof/pprof_**test.go
> +++ b/src/pkg/runtime/pprof/pprof_**test.go
> @@ -175,9 +175,9 @@
>
>  // Operating systems that are expected to fail the tests. See issue 6047.
>  var badOS = map[string]bool{
> -       "darwin":  true,
> -       "netbsd":  true,
> -       "openbsd": true,
> +       "darwin": true,
> +       //"netbsd":  true,
> +       //"openbsd": true,
>  }
>
>  func TestBlockProfile(t *testing.T) {
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[rsc, 2013-08-13 16:35:19]

On Tue, Aug 13, 2013 at 12:31 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote:

> What changed that these might work now?
>

Dmitriy fixed the test, which was not waiting for the background goroutine
to complete before checking the result. (Mac is still definitely broken
without my patch.)

Russ

[rsc, 2013-08-13 16:35:41]

*** Submitted as https://code.google.com/p/go/source/detail?r=ed695cdf962b ***

runtime/pprof: test netbsd and openbsd again

Maybe these will work now.

R=golang-dev, dvyukov, bradfitz
CC=golang-dev
https://codereview.appspot.com/12787044