Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(80)

Issue 12774043: code review 12774043: all: change textflags from numbers to symbols. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by khr
Modified:
11 years, 10 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

all: change textflags from numbers to symbols.

Patch Set 1 #

Patch Set 2 : diff -r d7db8c804ffa https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r d7db8c804ffa https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 4 : diff -r d7db8c804ffa https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 5 : diff -r 754f36b31d2d https://khr%40golang.org@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -196 lines) Patch
M src/pkg/crypto/aes/asm_amd64.s View 1 2 8 chunks +11 lines, -9 lines 0 comments Download
M src/pkg/crypto/md5/md5block_386.s View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M src/pkg/crypto/md5/md5block_amd64.s View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M src/pkg/crypto/md5/md5block_arm.s View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M src/pkg/crypto/rc4/rc4_386.s View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M src/pkg/crypto/rc4/rc4_amd64.s View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M src/pkg/crypto/rc4/rc4_arm.s View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M src/pkg/crypto/sha1/sha1block_386.s View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M src/pkg/crypto/sha1/sha1block_amd64.s View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M src/pkg/hash/crc32/crc32_amd64.s View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/pkg/math/big/arith_386.s View 1 2 12 chunks +14 lines, -12 lines 0 comments Download
M src/pkg/math/big/arith_amd64.s View 1 2 13 chunks +14 lines, -12 lines 0 comments Download
M src/pkg/math/big/arith_arm.s View 1 2 10 chunks +14 lines, -12 lines 0 comments Download
M src/pkg/os/signal/sig.s View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M src/pkg/reflect/asm_386.s View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/pkg/reflect/asm_amd64.s View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/pkg/reflect/asm_arm.s View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/pkg/runtime/cgo/asm_386.s View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M src/pkg/runtime/cgo/asm_amd64.s View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M src/pkg/runtime/cgo/asm_arm.s View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M src/pkg/sync/atomic/asm_386.s View 1 2 7 chunks +25 lines, -23 lines 0 comments Download
M src/pkg/sync/atomic/asm_amd64.s View 1 2 5 chunks +25 lines, -23 lines 0 comments Download
M src/pkg/sync/atomic/asm_arm.s View 1 2 8 chunks +11 lines, -9 lines 0 comments Download
M src/pkg/sync/atomic/asm_freebsd_arm.s View 1 2 3 chunks +25 lines, -23 lines 0 comments Download
M src/pkg/sync/atomic/asm_linux_arm.s View 1 2 9 chunks +30 lines, -28 lines 0 comments Download
M src/pkg/sync/atomic/asm_netbsd_arm.s View 1 2 3 chunks +25 lines, -23 lines 0 comments Download

Messages

Total messages: 3
khr
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/
11 years, 10 months ago (2013-08-12 16:34:11 UTC) #1
bradfitz
LGTM On Mon, Aug 12, 2013 at 9:34 AM, <khr@golang.org> wrote: > Reviewers: golang-dev1, > ...
11 years, 10 months ago (2013-08-12 16:38:23 UTC) #2
khr
11 years, 10 months ago (2013-08-12 17:25:39 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=39a586fa20b1 ***

all: change textflags from numbers to symbols.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12774043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b