Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8074)

Issue 12773047: Parse composite music in context modifications in \notemode (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by dak
Modified:
10 years, 6 months ago
Reviewers:
janek
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Parse composite music in context modifications in \notemode

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M lily/parser.yy View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 3
janek
Hi, could you write a 2-sentence explanation why we want to do this? Janek
10 years, 8 months ago (2013-08-27 07:43:41 UTC) #1
dak
On 2013/08/27 07:43:41, janek wrote: > Hi, > > could you write a 2-sentence explanation ...
10 years, 8 months ago (2013-08-27 08:56:51 UTC) #2
janek
10 years, 8 months ago (2013-08-27 09:10:30 UTC) #3
I like this!  Please put this example into commit message and/or a
comment in the code :)

best,
Janek

2013/8/27  <dak@gnu.org>:
> Reviewers: janek,
>
> Message:
>
> On 2013/08/27 07:43:41, janek wrote:
>>
>> Hi,
>
>
>> could you write a 2-sentence explanation why we want to do this?
>
>
>> Janek
>
>
> \new Staff \with { \transposition f' } { g a b c' }
>
>
> Description:
> Parse composite music in context modifications in \notemode
>
> Please review this at https://codereview.appspot.com/12773047/
>
> Affected files:
>   M lily/parser.yy
>
>
> Index: lily/parser.yy
> diff --git a/lily/parser.yy b/lily/parser.yy
> index
>
53bddf5eaf64dcf48824e05740d20d330919faab..f09e092dab0acddc4f6d5166a8164d36dd1d09a3
> 100644
> --- a/lily/parser.yy
> +++ b/lily/parser.yy
> @@ -627,7 +627,16 @@ context_def_spec_block:
>
>  context_mod_arg:
>         embedded_scm
> -       | composite_music
> +       |
> +       {
> +               SCM nn = parser->lexer_->lookup_identifier ("pitchnames");
> +               parser->lexer_->push_note_state (nn);
> +       }
> +       composite_music
> +       {
> +               parser->lexer_->pop_state ();
> +               $$ = $2;
> +       }
>         ;
>
>  context_mod_embedded:
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b