Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1727)

Issue 12773043: code review 12773043: syscall: Convert textflags from numbers to symbols. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by khr
Modified:
11 years, 10 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

syscall: Convert textflags from numbers to symbols.

Patch Set 1 #

Patch Set 2 : diff -r d7db8c804ffa https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r d7db8c804ffa https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 4 : diff -r d7db8c804ffa https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 5 : diff -r 3c7cac86a284 https://khr%40golang.org@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -79 lines) Patch
M src/pkg/syscall/asm_darwin_386.s View 1 6 chunks +7 lines, -5 lines 0 comments Download
M src/pkg/syscall/asm_darwin_amd64.s View 1 5 chunks +6 lines, -4 lines 0 comments Download
M src/pkg/syscall/asm_freebsd_386.s View 1 6 chunks +7 lines, -5 lines 0 comments Download
M src/pkg/syscall/asm_freebsd_amd64.s View 1 6 chunks +7 lines, -5 lines 0 comments Download
M src/pkg/syscall/asm_freebsd_arm.s View 1 6 chunks +7 lines, -5 lines 0 comments Download
M src/pkg/syscall/asm_linux_386.s View 1 8 chunks +9 lines, -7 lines 0 comments Download
M src/pkg/syscall/asm_linux_amd64.s View 1 7 chunks +8 lines, -6 lines 0 comments Download
M src/pkg/syscall/asm_linux_arm.s View 1 6 chunks +7 lines, -5 lines 0 comments Download
M src/pkg/syscall/asm_netbsd_386.s View 1 6 chunks +7 lines, -5 lines 0 comments Download
M src/pkg/syscall/asm_netbsd_amd64.s View 1 6 chunks +7 lines, -5 lines 0 comments Download
M src/pkg/syscall/asm_netbsd_arm.s View 1 6 chunks +7 lines, -5 lines 0 comments Download
M src/pkg/syscall/asm_openbsd_386.s View 1 6 chunks +7 lines, -5 lines 0 comments Download
M src/pkg/syscall/asm_openbsd_amd64.s View 1 6 chunks +7 lines, -5 lines 0 comments Download
M src/pkg/syscall/asm_plan9_386.s View 1 7 chunks +8 lines, -6 lines 0 comments Download
M src/pkg/syscall/asm_plan9_amd64.s View 1 7 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 3
khr
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/
11 years, 10 months ago (2013-08-12 16:33:26 UTC) #1
bradfitz
LGTM On Mon, Aug 12, 2013 at 9:33 AM, <khr@golang.org> wrote: > Reviewers: golang-dev1, > ...
11 years, 10 months ago (2013-08-12 16:38:30 UTC) #2
khr
11 years, 10 months ago (2013-08-12 17:24:32 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=0c243c3224c7 ***

syscall: Convert textflags from numbers to symbols.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12773043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b