LGTM On Mon, Aug 12, 2013 at 9:33 AM, <khr@golang.org> wrote: > Reviewers: golang-dev1, > ...
11 years, 10 months ago
(2013-08-12 16:38:30 UTC)
#2
LGTM
On Mon, Aug 12, 2013 at 9:33 AM, <khr@golang.org> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
>
https://khr%40golang.org@code.**google.com/p/go/<http://40golang.org@code.goo...
>
>
> Description:
> syscall: Convert textflags from numbers to symbols.
>
> Please review this at
https://codereview.appspot.**com/12773043/<https://codereview.appspot.com/127...
>
> Affected files:
> M src/pkg/syscall/asm_darwin_**386.s
> M src/pkg/syscall/asm_darwin_**amd64.s
> M src/pkg/syscall/asm_freebsd_**386.s
> M src/pkg/syscall/asm_freebsd_**amd64.s
> M src/pkg/syscall/asm_freebsd_**arm.s
> M src/pkg/syscall/asm_linux_386.**s
> M src/pkg/syscall/asm_linux_**amd64.s
> M src/pkg/syscall/asm_linux_arm.**s
> M src/pkg/syscall/asm_netbsd_**386.s
> M src/pkg/syscall/asm_netbsd_**amd64.s
> M src/pkg/syscall/asm_netbsd_**arm.s
> M src/pkg/syscall/asm_openbsd_**386.s
> M src/pkg/syscall/asm_openbsd_**amd64.s
> M src/pkg/syscall/asm_plan9_386.**s
> M src/pkg/syscall/asm_plan9_**amd64.s
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>
Issue 12773043: code review 12773043: syscall: Convert textflags from numbers to symbols.
(Closed)
Created 11 years, 10 months ago by khr
Modified 11 years, 10 months ago
Reviewers:
Base URL:
Comments: 0