Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(73)

Issue 12770043: Fixes settings save button

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by jeff.pihach
Modified:
11 years, 11 months ago
Reviewers:
benjamin.saller, mp+179738, j.c.sackett
Visibility:
Public.

Description

Fixes settings save button This fixes the inspector settings save button from changing to 'confirm' on click. It now clears the input fields which have the 'modified' class added from the databinding system and adds a test. https://code.launchpad.net/~hatch/juju-gui/save-changes-1210154/+merge/179738 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixes settings save button #

Patch Set 3 : Fixes settings save button #

Patch Set 4 : Fixes settings save button #

Patch Set 5 : Fixes settings save button #

Patch Set 6 : Fixes settings save button #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/templates/viewlet-manager.handlebars View 1 chunk +1 line, -0 lines 0 comments Download
M app/views/inspector.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/test_inspector_settings.js View 1 2 2 chunks +27 lines, -2 lines 0 comments Download

Messages

Total messages: 5
jeff.pihach
Please take a look.
11 years, 11 months ago (2013-08-12 15:56:54 UTC) #1
j.c.sackett
LGTM, but one question below. https://codereview.appspot.com/12770043/diff/1/test/test_inspector_settings.js File test/test_inspector_settings.js (right): https://codereview.appspot.com/12770043/diff/1/test/test_inspector_settings.js#newcode297 test/test_inspector_settings.js:297: }); Don't you want ...
11 years, 11 months ago (2013-08-12 16:18:51 UTC) #2
benjamin.saller
LGTM The inspector wires show the button text sometimes as confirm and sometimes as save ...
11 years, 11 months ago (2013-08-12 17:58:36 UTC) #3
jeff.pihach
Thanks for the reviews! A few more checks in the tests were added. https://codereview.appspot.com/12770043/diff/1/test/test_inspector_settings.js File ...
11 years, 11 months ago (2013-08-12 18:14:26 UTC) #4
jeff.pihach
11 years, 11 months ago (2013-08-12 20:09:52 UTC) #5
*** Submitted:

Fixes settings save button

This fixes the inspector settings save button from
changing to 'confirm' on click. It now clears the input
fields which have the 'modified' class added from the 
databinding system and adds a test.

R=j.c.sackett, benjamin.saller
CC=
https://codereview.appspot.com/12770043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b