Replaces use of Charm with Browsercharm everywhere

Replaces use of Charm with Browsercharm everywhere

-DB no longer has a browserCharms field; just charms, which is a BrowserCharm
list.
-parse has been updated to handle BrowserCharm's relations{requires, provides}
structure.
-Old JSON files have mostly been removed.
-Tests have been updated.

https://code.launchpad.net/~jcsackett/juju-gui/browsercharm-everywhere/+merge/179726

(do not edit description out of merge proposal)

[j.c.sackett, 2013-08-12 15:22:01]

Please take a look.

[rharding, 2013-08-12 16:55:56]

Code looks good with the small comments and one question below. 

Will QA and get back for final ok.

https://codereview.appspot.com/12768043/diff/1/app/widgets/charm-token.js
File app/widgets/charm-token.js (right):

https://codereview.appspot.com/12768043/diff/1/app/widgets/charm-token.js#new...
app/widgets/charm-token.js:53: this.charmData.id = cfg.id;
why is the id split out here?

https://codereview.appspot.com/12768043/diff/1/test/test_inspector_overview.js
File test/test_inspector_overview.js (right):

https://codereview.appspot.com/12768043/diff/1/test/test_inspector_overview.j...
test/test_inspector_overview.js:35: 'data/mediawiki-api-response.json',
indent here please

https://codereview.appspot.com/12768043/diff/1/test/test_inspector_settings.js
File test/test_inspector_settings.js (right):

https://codereview.appspot.com/12768043/diff/1/test/test_inspector_settings.j...
test/test_inspector_settings.js:34: 'data/mediawiki-api-response.json',
same indent here. I think 4spaces passes linter.

[jeff.pihach, 2013-08-12 17:18:30]

This is awesome I can't wait until it's completely done.
LGTM and QA OK

https://codereview.appspot.com/12768043/diff/1/app/models/models.js
File app/models/models.js (right):

https://codereview.appspot.com/12768043/diff/1/app/models/models.js#newcode702
app/models/models.js:702: this.charms = new models.BrowserCharmList();
I wonder if these should be renamed to simply Charm/List because there will no
longer be a browser soonish.

https://codereview.appspot.com/12768043/diff/1/app/views/viewlets/charm-detai...
File app/views/viewlets/charm-details.js (right):

https://codereview.appspot.com/12768043/diff/1/app/views/viewlets/charm-detai...
app/views/viewlets/charm-details.js:71: }, this, viewletManagerAttrs.db.charms);
this is a little confusing because everything else was converted to browser
charm but you can leave it if the end goal is to change everything back to charm

https://codereview.appspot.com/12768043/diff/1/test/test_model.js
File test/test_model.js (left):

https://codereview.appspot.com/12768043/diff/1/test/test_model.js#oldcode21
test/test_model.js:21: describe('Charm and BrowserCharm initialization',
function() {
This cleanup is so awesome.

[j.c.sackett, 2013-08-12 17:40:54]

https://codereview.appspot.com/12768043/diff/1/app/models/models.js
File app/models/models.js (right):

https://codereview.appspot.com/12768043/diff/1/app/models/models.js#newcode702
app/models/models.js:702: this.charms = new models.BrowserCharmList();
On 2013/08/12 17:18:31, jeff.pihach wrote:
> I wonder if these should be renamed to simply Charm/List because there will no
> longer be a browser soonish.

As we discussed on IRC, we'll remove BrowserCharm and BrowserCharmList as names
when we remove the Charm model.

https://codereview.appspot.com/12768043/diff/1/app/views/viewlets/charm-detai...
File app/views/viewlets/charm-details.js (right):

https://codereview.appspot.com/12768043/diff/1/app/views/viewlets/charm-detai...
app/views/viewlets/charm-details.js:71: }, this, viewletManagerAttrs.db.charms);
On 2013/08/12 17:18:31, jeff.pihach wrote:
> this is a little confusing because everything else was converted to browser
> charm but you can leave it if the end goal is to change everything back to
charm

It was expediency; there are *way* more references to db.charms than
db.browserCharms, so killing that and making charms = BrowserCharmList made more
sense.

Conceptually it's the database of charms, and the only charms in existence are
BrowserCharms.

https://codereview.appspot.com/12768043/diff/1/app/widgets/charm-token.js
File app/widgets/charm-token.js (right):

https://codereview.appspot.com/12768043/diff/1/app/widgets/charm-token.js#new...
app/widgets/charm-token.js:53: this.charmData.id = cfg.id;
On 2013/08/12 16:55:56, rharding wrote:
> why is the id split out here? 

Because it wasn't picking up "id" from the keys of BrowserCharm.ATTRs, but I
just realized that's because I didn't get 'id' added to the ATTRs when breaking
BrowserCharm off from Charm. Didn't break anything because we manually set 'id'
in the initializer.

I've updated the ATTRs and killed that line.

https://codereview.appspot.com/12768043/diff/1/test/test_inspector_overview.js
File test/test_inspector_overview.js (right):

https://codereview.appspot.com/12768043/diff/1/test/test_inspector_overview.j...
test/test_inspector_overview.js:35: 'data/mediawiki-api-response.json',
On 2013/08/12 16:55:56, rharding wrote:
> indent here please

Huh; weirdly I *had* indented here. I think we can't trust the fixes "make prep"
make.

https://codereview.appspot.com/12768043/diff/1/test/test_inspector_settings.js
File test/test_inspector_settings.js (right):

https://codereview.appspot.com/12768043/diff/1/test/test_inspector_settings.j...
test/test_inspector_settings.js:34: 'data/mediawiki-api-response.json',
On 2013/08/12 16:55:56, rharding wrote:
> same indent here. I think 4spaces passes linter.
Same again. Definitely not trusting make prep.

https://codereview.appspot.com/12768043/diff/1/test/test_model.js
File test/test_model.js (left):

https://codereview.appspot.com/12768043/diff/1/test/test_model.js#oldcode21
test/test_model.js:21: describe('Charm and BrowserCharm initialization',
function() {
On 2013/08/12 17:18:31, jeff.pihach wrote:
> This cleanup is so awesome.

:-P I do so love deleting code. :-)

[rharding, 2013-08-12 18:07:50]

LGTM

Leaving the below in case I can somehow duplicate it, but I'm striking out now
that I've sat down to write up instructions.

-------------------------


QA'd almost ok. If I deploy a service, click on view, and go to the charm, it
auto reloads every couple of seconds. Example url I hit.

http://gui:8888/:gui:/charms/charms/precise/ceph-14/json/

It does not do it on jujucharms.com.


Of course, now that I'm writing this up I can't duplicate it. There is a double
dispatch in there. So nvm

[j.c.sackett, 2013-08-12 19:27:58]

On 2013/08/12 18:07:50, rharding wrote:
> LGTM
> 
> Leaving the below in case I can somehow duplicate it, but I'm striking out now
> that I've sat down to write up instructions.
> 
> -------------------------
> 
> 
> QA'd almost ok. If I deploy a service, click on view, and go to the charm, it
> auto reloads every couple of seconds. Example url I hit.
> 
> http://gui:8888/:gui:/charms/charms/precise/ceph-14/json/
> 
> It does not do it on http://jujucharms.com.
> 
> 
> Of course, now that I'm writing this up I can't duplicate it. There is a
double
> dispatch in there. So nvm

Yeah, I've encountered that a time or two in several branches, and can
periodically replicate in trunk. But it's in a view that's being removed once
inspector comes online, so...

[j.c.sackett, 2013-08-12 19:30:26]

Please take a look.

[j.c.sackett, 2013-08-12 23:26:51]

*** Submitted:

Replaces use of Charm with Browsercharm everywhere

-DB no longer has a browserCharms field; just charms, which is a BrowserCharm
list.
-parse has been updated to handle BrowserCharm's relations{requires, provides}
structure.
-Old JSON files have mostly been removed.
-Tests have been updated.

R=rharding, jeff.pihach
CC=
https://codereview.appspot.com/12768043