apiserver/uniter: Open/ClosePorts, (Set)CharmURL

apiserver/uniter: Open/ClosePorts, (Set)CharmURL

This implements the following additional uniter API calls:
* SetCharmURL
* CharmURL
* OpenPort
* ClosePort

In addition, some minor refactoring was done to the uniter tests.

https://code.launchpad.net/~dimitern/juju-core/097-apiserver-uniter-unit-ops5/+merge/179683

Requires: https://code.launchpad.net/~dimitern/juju-core/096-apiserver-uniter-unit-ops4/+merge/179661

(do not edit description out of merge proposal)

[dimitern, 2013-08-12 12:10:32]

Please take a look.

[rog, 2013-08-12 15:32:03]

LGTM modulo some thoughts below.

https://codereview.appspot.com/12756043/diff/1/state/api/params/internal.go
File state/api/params/internal.go (right):

https://codereview.appspot.com/12756043/diff/1/state/api/params/internal.go#n...
state/api/params/internal.go:48: type EntityCharmURL struct {
Could we declare this next to EntitiesCharmURL please?

https://codereview.appspot.com/12756043/diff/1/state/api/params/internal.go#n...
state/api/params/internal.go:61: // ClosePort on an entity.
s/an entity/some entities./

https://codereview.appspot.com/12756043/diff/1/state/api/params/internal.go#n...
state/api/params/internal.go:62: type EntitiesPorts struct {
If we have EntitiesCharmURL below, then this should probably be EntitiesPort for
consistency (or vice versa).

[dimitern, 2013-08-12 15:41:54]

Please take a look.

https://codereview.appspot.com/12756043/diff/1/state/api/params/internal.go
File state/api/params/internal.go (right):

https://codereview.appspot.com/12756043/diff/1/state/api/params/internal.go#n...
state/api/params/internal.go:48: type EntityCharmURL struct {
On 2013/08/12 15:32:03, rog wrote:
> Could we declare this next to EntitiesCharmURL please?

Sure, done.

https://codereview.appspot.com/12756043/diff/1/state/api/params/internal.go#n...
state/api/params/internal.go:61: // ClosePort on an entity.
On 2013/08/12 15:32:03, rog wrote:
> s/an entity/some entities./

Done.

https://codereview.appspot.com/12756043/diff/1/state/api/params/internal.go#n...
state/api/params/internal.go:62: type EntitiesPorts struct {
On 2013/08/12 15:32:03, rog wrote:
> If we have EntitiesCharmURL below, then this should probably be EntitiesPort
for
> consistency (or vice versa).

It is consistent - EntityCharmURL / EntitiesCharmURL vs. EntityPort /
EntitiesPorts. It's like StringBoolResult / StringBoolResults, but entities is
plural to emphasize the similarity to Entities and Entity.

[gz, 2013-08-12 15:50:11]

LGTM.