Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(49)

Issue 127440043: code review 127440043: cmd/ld: fix undefined behaviour in pcln.c (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by dave
Modified:
10 years, 6 months ago
Reviewers:
r
CC:
golang-codereviews, r
Visibility:
Public.

Description

cmd/ld: fix undefined behaviour in pcln.c Update issue 8527 Fixes, src/cmd/6l/../ld/pcln.c:93:18: runtime error: left shift of negative value -2

Patch Set 1 #

Patch Set 2 : diff -r 68b973321bb5549232677c4abfd0180d52c11269 https://code.google.com/p/go #

Patch Set 3 : diff -r 68b973321bb5549232677c4abfd0180d52c11269 https://code.google.com/p/go #

Patch Set 4 : diff -r 68b973321bb5549232677c4abfd0180d52c11269 https://code.google.com/p/go #

Patch Set 5 : diff -r 1991f0eb1bb4fa59d6d9ed8835d892bd2c340430 https://code.google.com/p/go #

Patch Set 6 : diff -r 16bc5182facfac06edf06eb768ff7bd4be4f4967 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/ld/pcln.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
dave_cheney.net
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 7 months ago (2014-08-19 03:33:58 UTC) #1
r
LGTM
10 years, 6 months ago (2014-08-21 19:54:09 UTC) #2
dave_cheney.net
10 years, 6 months ago (2014-08-21 23:10:48 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=19c11dcab770 ***

cmd/ld: fix undefined behaviour in pcln.c

Update issue 8527

Fixes, src/cmd/6l/../ld/pcln.c:93:18: runtime error: left shift of negative
value -2

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/127440043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b