Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3403)

Issue 12741051: GUI server: bundles support integration.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by frankban
Modified:
10 years, 8 months ago
Reviewers:
bac, rharding, mp+182067
Visibility:
Public.

Description

GUI server: bundles support integration. This branch enables the GUI server bundles support. Changed the hooks so that the new GUI server dependencies are installed. Also added more info to the info handler. Tests: `make unittest` from the branch root. QA: In the steps below I assume your default juju is juju-core and your juju-core env is named "go". - Bootstrap a juju-core environment: juju bootstrap -e go --upload-tools - From the root of this branch, deploy and expose the GUI running the following: make deploy JUJU_ENV=go The command above will exit when the GUI is ready. - Switch to the GUI server, then wait a minute for the server to be ready: juju set -e go juju-gui builtin-server=true - In a separate terminal tab, start watching the GUI server log (the first line should be "starting Juju GUI server v0.1.0"): juju ssh -e go 1 sudo tailf /var/log/upstart/guiserver.log - Use the browser to navigate the GUI, log in and check everything works fine. - Also visit the /gui-server-info URL path: you should see something like: { "uptime": 77, "deployer": [], "apiversion": "go", "version": "0.1.0", "debug": false, "apiurl": "wss://ec2-54-211-156-178.compute-1.amazonaws.com:17070" } - Let's live test the deployer support: to do that, we will use the script in http://pastebin.ubuntu.com/6028073/ - Download the script, edit the PASSWORD value (line 17) and execute it passing the Juju GUI node address as first argument, e.g.: python start-deployer.py ec2-54-227-188-14.compute-1.amazonaws.com - The script runs several API calls, simulates errors in the API parameters (which should also be notified in the GUI server logs), starts two deployments and start watching the second one. It takes some minutes to complete. In the meanwhile, you should be able to see the relevant changes in the topology view. At the end of the process, the GUI should show three started services (wordpress and mysql, connected to each other, and mediawiki), and the output of the script should be similar to this one: http://pastebin.ubuntu.com/6028121/ Note that I added a card to create a charm functional test that automates this live check. - Switch back to the legacy server (haproxy + apaxche2): juju set -e go juju-gui builtin-server=false - Refresh the browser and check everything is ok. Done, thank you! https://code.launchpad.net/~frankban/charms/precise/juju-gui/guiserver-bundles-integration/+merge/182067 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : GUI server: bundles support integration. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -33 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
A deps/futures-2.1.4.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
A deps/juju-deployer-0.2.2.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
A deps/jujuclient-0.0.9.tar.gz View 0 chunks +-1 lines, --1 lines 0 comments Download
M hooks/backend.py View 1 chunk +3 lines, -2 lines 0 comments Download
M hooks/utils.py View 2 chunks +12 lines, -8 lines 0 comments Download
M revision View 1 chunk +1 line, -1 line 0 comments Download
M server/guiserver/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M server/guiserver/apps.py View 4 chunks +13 lines, -1 line 0 comments Download
M server/guiserver/handlers.py View 7 chunks +37 lines, -6 lines 0 comments Download
M server/guiserver/tests/helpers.py View 1 chunk +13 lines, -0 lines 0 comments Download
M server/guiserver/tests/test_apps.py View 3 chunks +33 lines, -6 lines 0 comments Download
M server/guiserver/tests/test_handlers.py View 6 chunks +66 lines, -3 lines 0 comments Download
M server/guiserver/tests/test_utils.py View 1 chunk +40 lines, -0 lines 0 comments Download
M server/guiserver/utils.py View 2 chunks +24 lines, -0 lines 0 comments Download
M server/setup.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/test_backends.py View 2 chunks +1 line, -2 lines 0 comments Download
M tests/test_utils.py View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
10 years, 8 months ago (2013-08-26 10:29:32 UTC) #1
bac
Code LGTM and the QA worked perfectly. Thanks for the detailed QA instructions. https://codereview.appspot.com/12741051/diff/1/server/guiserver/utils.py File ...
10 years, 8 months ago (2013-08-26 15:31:05 UTC) #2
rharding
LGTM
10 years, 8 months ago (2013-08-27 16:47:08 UTC) #3
frankban
*** Submitted: GUI server: bundles support integration. This branch enables the GUI server bundles support. ...
10 years, 8 months ago (2013-08-27 16:59:39 UTC) #4
frankban
10 years, 8 months ago (2013-08-27 17:04:10 UTC) #5
Thanks Brad and Rick for the reviews!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b