Issue 12741050: Removes the category links on editorial.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12741050: Removes the category links on editorial.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by j.c.sackett

Modified:
10 years, 8 months ago

Reviewers:
rharding, mp+181820, matthew.scott

Visibility:
Public.

Description

Removes the category links on editorial. * Category links removed from editorial template * Category Partial deleted * Category link events and tests removed. https://code.launchpad.net/~jcsackett/juju-gui/remove-categories/+merge/181820 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Removes the category links on editorial. #

Patch Set 3 : Removes the category links on editorial. #

Patch Set 4 : Removes the category links on editorial. #

Patch Set 5 : Removes the category links on editorial. #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -130 lines)			Patch
A	[revision details]	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/browser.js	View		1 chunk	+0 lines, -11 lines	0 comments	Download
M	app/subapps/browser/templates/editorial.handlebars	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	app/subapps/browser/views/editorial.js	View		3 chunks	+0 lines, -31 lines	0 comments	Download
D	app/templates/category-icons.partial	View		1 chunk	+0 lines, -57 lines	0 comments	Download
M	lib/views/browser/charm-full.less	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/views/browser/charm-token.less	View		3 chunks	+0 lines, -9 lines	0 comments	Download
M	test/test_browser_editorial.js	View		1 chunk	+0 lines, -20 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

matthew.scott

LGTM - sad to see it go, since I just fixed the icons last week ...

10 years, 8 months ago (2013-08-23 14:20:51 UTC) #3

j.c.sackett

10 years, 8 months ago (2013-08-27 14:15:10 UTC) #5

*** Submitted:

Removes the category links on editorial.

* Category links removed from editorial template
* Category Partial deleted
* Category link events and tests removed.

R=matthew.scott, rharding
CC=
https://codereview.appspot.com/12741050

Expand All Messages | Collapse All Messages