Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(50)

Issue 12741047: code review 12741047: misc/xcode: use `xcode-select` to determine path (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by cehessman
Modified:
11 years, 8 months ago
Reviewers:
r
CC:
golang-dev, r
Visibility:
Public.

Description

misc/xcode: use `xcode-select` to determine path If xcode-select is available, use it to determine the path to the DVTFoundation.xcplugindata file. Fixes issue 5997.

Patch Set 1 #

Patch Set 2 : diff -r 9b8afda16f02 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 9b8afda16f02 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M misc/xcode/4/go4xcode.sh View 1 3 chunks +19 lines, -7 lines 0 comments Download

Messages

Total messages: 3
cehessman
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 8 months ago (2013-08-18 12:47:10 UTC) #1
r
LGTM thanks
11 years, 8 months ago (2013-08-20 10:47:58 UTC) #2
r
11 years, 8 months ago (2013-08-20 10:48:41 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=cc5f0ff8fb61 ***

misc/xcode: use `xcode-select` to determine path

If xcode-select is available, use it to determine the path to the
DVTFoundation.xcplugindata file.

Fixes issue 5997.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/12741047

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b