Issue 12741044: code review 12741044: cmd/dist: fix darwin build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12741044: code review 12741044: cmd/dist: fix darwin build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by rsc

Modified:
11 years, 10 months ago

Reviewers:
elias.naur

CC:
golang-dev

Visibility:
Public.

Description

cmd/dist: fix darwin build The TLS block on Darwin is not the same as on ELF.

Patch Set 1 #

Patch Set 2 : diff -r fe09d6a5fa96 https://code.google.com/p/go/ #

Patch Set 3 : diff -r fe09d6a5fa96 https://code.google.com/p/go/ #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
M	src/cmd/dist/buildruntime.c	View	1	1 chunk	+6 lines, -7 lines	0 comments	Download
M	src/cmd/ld/data.c	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/ld/lib.c	View	1 2	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello elias.naur@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 10 months ago (2013-08-14 16:57:05 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=52572649a0d2 *** cmd/dist: fix darwin build The TLS block on Darwin is ...

11 years, 10 months ago (2013-08-14 16:57:10 UTC) #2

elias.naur

11 years, 10 months ago (2013-08-14 20:17:11 UTC) #3

Message was sent while issue was closed.

On 2013/08/14 16:57:10, rsc wrote:
> *** Submitted as https://code.google.com/p/go/source/detail?r=52572649a0d2 ***
> 
> cmd/dist: fix darwin build
> 
> The TLS block on Darwin is not the same as on ELF.
> 
> TBR=elias.naur
> CC=golang-dev
> https://codereview.appspot.com/12741044

LGTM

Small correction in https://codereview.appspot.com/12949043.

Expand All Messages | Collapse All Messages