code review 12730043: net: rearrange the call order of runtime-integrated net...

net: rearrange the call order of runtime-integrated network pollster and syscall functions

This CL rearranges the call order for raw networking primitives like
the following;

- For dialers that open active connections, pollDesc.Init will be
  called before syscall.Connect.

- For stream listeners that open passive stream connections,
  pollDesc.Init will be called just after syscall.Listen.

- For datagram listeners that open datagram connections,
  pollDesc.Init will be called just after syscall.Bind.

This is in preparation for runtime-integrated network pollster for BSD
variants.

Update issue 5199

[mikio, 2013-08-15 03:01:16]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[brainman, 2013-08-15 04:30:57]

I would rather see you change one thing at a time. I loose track of what is
happening very quickly. Sorry.

Do you know, that we call syscall.Bind in connect in fd_windows.go? I am not
sure, if it matters.

Alex

[mikio, 2013-08-15 06:00:29]

On 2013/08/15 04:30:57, brainman wrote:
> I would rather see you change one thing at a time. I loose track of what is
> happening very quickly. Sorry.

Sorry, but I don't know another way wrapping a CL that will
never break the build.

> Do you know, that we call syscall.Bind in connect in fd_windows.go? I am not
> sure, if it matters.

Thanks for the notice. For ConnectEx on Windows, it requires
a named socket for its internal work, right? It doesn't matter
and I will fix the CL description something like;

- For dialers that open active connections, pollDesc.Init will be 
   called before syscall.Connect.

Probably we will revisit this when we support SCTP or MP-TCP
like stuff that needs complicated operations for both namespace
and connection control concurrently, but not now.

[brainman, 2013-08-15 07:12:42]

LGTM

I also tested it on windows-386 and windows-amd64. Fingers crossed. :-)

Alex

[mikio, 2013-08-15 07:40:41]

*** Submitted as https://code.google.com/p/go/source/detail?r=2b3a349b4b6c ***

net: rearrange the call order of runtime-integrated network pollster and syscall
functions

This CL rearranges the call order for raw networking primitives like
the following;

- For dialers that open active connections, pollDesc.Init will be
  called before syscall.Connect.

- For stream listeners that open passive stream connections,
  pollDesc.Init will be called just after syscall.Listen.

- For datagram listeners that open datagram connections,
  pollDesc.Init will be called just after syscall.Bind.

This is in preparation for runtime-integrated network pollster for BSD
variants.

Update issue 5199

R=golang-dev, alex.brainman
CC=golang-dev
https://codereview.appspot.com/12730043