code review 12706043: time: make Time implement encoding interfaces

time: make Time implement encoding interfaces

See golang.org/s/go12encoding for design.

[rsc, 2013-08-09 19:30:53]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-08-09 19:34:23]

LGTM

https://codereview.appspot.com/12706043/diff/8001/src/pkg/time/time.go
File src/pkg/time/time.go (right):

https://codereview.appspot.com/12706043/diff/8001/src/pkg/time/time.go#newcod...
src/pkg/time/time.go:951: // Time is formatted as RFC3339.
RFC3339Nano is used below. Or do you mean "RFC 3339" in general, and not the
constant?

[rsc, 2013-08-09 19:39:26]

On Fri, Aug 9, 2013 at 3:34 PM, <bradfitz@golang.org> wrote:

> https://codereview.appspot.**com/12706043/diff/8001/src/**
>
pkg/time/time.go#newcode951<https://codereview.appspot.com/12706043/diff/8001/src/pkg/time/time.go#newcode951>
> src/pkg/time/time.go:951: // Time is formatted as RFC3339.
> RFC3339Nano is used below. Or do you mean "RFC 3339" in general, and not
> the constant?
>

I just copied what JSON said, and RFC3339Nano didn't exist when that line
was written.
But I've updated them to refer to the RFC, not to a pattern. RFC3339Nano
would be the pattern to refer to, but I don't want people to not look
closely and conclude that nanoseconds are required.

// MarshalJSON implements the json.Marshaler interface.
// The time is a quoted string in RFC 3339 format, with sub-second
precision added if present.

// UnmarshalJSON implements the json.Unmarshaler interface.
// The time is expected to be a quoted string in RFC 3339 format.

// MarshalText implements the encoding.TextMarshaler interface.
// The time is formatted in RFC 3339 format, with sub-second precision
added if present.

// UnmarshalText implements the encoding.TextUnmarshaler interface.
// The time is expected to be in RFC 3339 format.

Russ

[bradfitz, 2013-08-09 19:50:06]

LGTM



On Fri, Aug 9, 2013 at 12:39 PM, Russ Cox <rsc@golang.org> wrote:

> On Fri, Aug 9, 2013 at 3:34 PM, <bradfitz@golang.org> wrote:
>
>> https://codereview.appspot.**com/12706043/diff/8001/src/**
>>
pkg/time/time.go#newcode951<https://codereview.appspot.com/12706043/diff/8001/src/pkg/time/time.go#newcode951>
>> src/pkg/time/time.go:951: // Time is formatted as RFC3339.
>> RFC3339Nano is used below. Or do you mean "RFC 3339" in general, and not
>> the constant?
>>
>
> I just copied what JSON said, and RFC3339Nano didn't exist when that line
> was written.
> But I've updated them to refer to the RFC, not to a pattern. RFC3339Nano
> would be the pattern to refer to, but I don't want people to not look
> closely and conclude that nanoseconds are required.
>
> // MarshalJSON implements the json.Marshaler interface.
> // The time is a quoted string in RFC 3339 format, with sub-second
> precision added if present.
>
> // UnmarshalJSON implements the json.Unmarshaler interface.
> // The time is expected to be a quoted string in RFC 3339 format.
>
> // MarshalText implements the encoding.TextMarshaler interface.
> // The time is formatted in RFC 3339 format, with sub-second precision
> added if present.
>
> // UnmarshalText implements the encoding.TextUnmarshaler interface.
> // The time is expected to be in RFC 3339 format.
>
> Russ
>
>

[rsc, 2013-08-14 04:34:04]

*** Submitted as https://code.google.com/p/go/source/detail?r=45e8e962d87b ***

time: make Time implement encoding interfaces

See golang.org/s/go12encoding for design.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12706043