Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(270)

Issue 12706043: code review 12706043: time: make Time implement encoding interfaces (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by rsc
Modified:
4 years, 3 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

time: make Time implement encoding interfaces See golang.org/s/go12encoding for design.

Patch Set 1 #

Patch Set 2 : diff -r b1c9e72c2ca3 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b1c9e72c2ca3 https://code.google.com/p/go/ #

Patch Set 4 : diff -r b1c9e72c2ca3 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 5 : diff -r b1c9e72c2ca3 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 7c4368941249 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -21 lines) Patch
M src/pkg/time/time.go View 1 2 3 4 5 5 chunks +46 lines, -14 lines 0 comments Download
M src/pkg/time/time_test.go View 1 2 4 chunks +15 lines, -7 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
4 years, 3 months ago (2013-08-09 19:30:53 UTC) #1
bradfitz
LGTM https://codereview.appspot.com/12706043/diff/8001/src/pkg/time/time.go File src/pkg/time/time.go (right): https://codereview.appspot.com/12706043/diff/8001/src/pkg/time/time.go#newcode951 src/pkg/time/time.go:951: // Time is formatted as RFC3339. RFC3339Nano is ...
4 years, 3 months ago (2013-08-09 19:34:23 UTC) #2
rsc
On Fri, Aug 9, 2013 at 3:34 PM, <bradfitz@golang.org> wrote: > https://codereview.appspot.**com/12706043/diff/8001/src/** > pkg/time/time.go#newcode951<https://codereview.appspot.com/12706043/diff/8001/src/pkg/time/time.go#newcode951> > ...
4 years, 3 months ago (2013-08-09 19:39:26 UTC) #3
bradfitz
LGTM On Fri, Aug 9, 2013 at 12:39 PM, Russ Cox <rsc@golang.org> wrote: > On ...
4 years, 3 months ago (2013-08-09 19:50:06 UTC) #4
rsc
4 years, 3 months ago (2013-08-14 04:34:04 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=45e8e962d87b ***

time: make Time implement encoding interfaces

See golang.org/s/go12encoding for design.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12706043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4