Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(162)

Issue 12705043: code review 12705043: net: make IP implement encoding.MarshalerText, encoding... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by rsc
Modified:
4 years, 3 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz, mikio
Visibility:
Public.

Description

net: make IP implement encoding.MarshalerText, encoding.UnmarshalerText See golang.org/s/go12encoding for design.

Patch Set 1 #

Patch Set 2 : diff -r b1c9e72c2ca3 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r 4204b561812c https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M src/pkg/net/ip.go View 1 2 chunks +23 lines, -0 lines 0 comments Download
M src/pkg/net/ip_test.go View 1 3 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
4 years, 3 months ago (2013-08-09 19:31:11 UTC) #1
bradfitz
LGTM On Fri, Aug 9, 2013 at 12:31 PM, <rsc@golang.org> wrote: > Reviewers: golang-dev1, > ...
4 years, 3 months ago (2013-08-09 19:31:59 UTC) #2
mikio
Fixes issue 5086? https://codereview.appspot.com/12705043/diff/3001/src/pkg/net/ip.go File src/pkg/net/ip.go (right): https://codereview.appspot.com/12705043/diff/3001/src/pkg/net/ip.go#newcode319 src/pkg/net/ip.go:319: return nil, errors.New("invalid IP address") why ...
4 years, 3 months ago (2013-08-10 00:05:25 UTC) #3
rsc
4 years, 3 months ago (2013-08-14 04:33:24 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=7c4368941249 ***

net: make IP implement encoding.MarshalerText, encoding.UnmarshalerText

See golang.org/s/go12encoding for design.

R=golang-dev, bradfitz, mikioh.mikioh
CC=golang-dev
https://codereview.appspot.com/12705043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4