Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(265)

Issue 12703043: code review 12703043: encoding/json: support encoding.TextMarshaler, encoding... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by rsc
Modified:
4 years, 3 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

encoding/json: support encoding.TextMarshaler, encoding.TextUnmarshaler

Patch Set 1 #

Patch Set 2 : diff -r b1c9e72c2ca3 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b1c9e72c2ca3 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 4204b561812c https://code.google.com/p/go/ #

Total comments: 1

Patch Set 5 : diff -r f95838c0a419 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -26 lines) Patch
M src/pkg/encoding/json/decode.go View 1 2 5 chunks +53 lines, -13 lines 0 comments Download
M src/pkg/encoding/json/decode_test.go View 1 2 3 4 7 chunks +43 lines, -3 lines 0 comments Download
M src/pkg/encoding/json/encode.go View 1 2 3 7 chunks +124 lines, -6 lines 0 comments Download
M src/pkg/encoding/json/encode_test.go View 1 2 3 4 chunks +95 lines, -4 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
4 years, 3 months ago (2013-08-09 19:09:44 UTC) #1
bradfitz
https://codereview.appspot.com/12703043/diff/6001/src/pkg/encoding/json/encode.go File src/pkg/encoding/json/encode.go (right): https://codereview.appspot.com/12703043/diff/6001/src/pkg/encoding/json/encode.go#newcode847 src/pkg/encoding/json/encode.go:847: func (e *encodeState) stringBytes(s []byte) (int, error) { this ...
4 years, 3 months ago (2013-08-09 20:04:16 UTC) #2
rsc
PTAL I added a test for the two functions being in sync.
4 years, 3 months ago (2013-08-14 04:32:27 UTC) #3
bradfitz
LGTM https://codereview.appspot.com/12703043/diff/10001/src/pkg/encoding/json/decode_test.go File src/pkg/encoding/json/decode_test.go (right): https://codereview.appspot.com/12703043/diff/10001/src/pkg/encoding/json/decode_test.go#newcode79 src/pkg/encoding/json/decode_test.go:79: *u = unmarshalerText{true} // All we need to ...
4 years, 3 months ago (2013-08-14 18:04:53 UTC) #4
rsc
4 years, 3 months ago (2013-08-14 18:56:10 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=117ed8ab3db0 ***

encoding/json: support encoding.TextMarshaler, encoding.TextUnmarshaler

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12703043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4