code review 127030043: cmd/cover: show file coverage in HTML drop down

cmd/cover: show file coverage in HTML drop down

As requested on Stack Overflow: http://goo.gl/ams9fY
(Kudos to sberry for his JavaScript solution, provided there.
This change does the same thing on the server side.)

[adg, 2014-08-11 01:12:36]

Hello r (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.tools

[r, 2014-08-11 17:49:40]

LGTM

https://codereview.appspot.com/127030043/diff/1/cmd/cover/html.go
File cmd/cover/html.go (right):

https://codereview.appspot.com/127030043/diff/1/cmd/cover/html.go#newcode87
cmd/cover/html.go:87: func percentCovered(p *cover.Profile) float64 {
// percentCovered returns, as a percentage, the fraction of the statements in
the profile
// covered by the test run. In effect, it reports the coverage of a given source
file.

https://codereview.appspot.com/127030043/diff/1/cmd/cover/html.go#newcode98
cmd/cover/html.go:98: return float64(covered) / float64(total) * 100
this is the third place this calculation is done but i don't see a nice way to
unify things

[adg, 2014-08-11 23:22:23]

*** Submitted as
https://code.google.com/p/go/source/detail?r=860d696fb7c2&repo=tools ***

cmd/cover: show file coverage in HTML drop down

As requested on Stack Overflow: http://goo.gl/ams9fY
(Kudos to sberry for his JavaScript solution, provided there.
This change does the same thing on the server side.)

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/127030043

https://codereview.appspot.com/127030043/diff/1/cmd/cover/html.go
File cmd/cover/html.go (right):

https://codereview.appspot.com/127030043/diff/1/cmd/cover/html.go#newcode87
cmd/cover/html.go:87: func percentCovered(p *cover.Profile) float64 {
On 2014/08/11 17:49:40, r wrote:
> // percentCovered returns, as a percentage, the fraction of the statements in
> the profile
> // covered by the test run. In effect, it reports the coverage of a given
source
> file.

Done.

https://codereview.appspot.com/127030043/diff/1/cmd/cover/html.go#newcode98
cmd/cover/html.go:98: return float64(covered) / float64(total) * 100
On 2014/08/11 17:49:40, r wrote:
> this is the third place this calculation is done but i don't see a nice way to
> unify things

I came to the same conclusion.