code review 12699045: runtime: fix openbsd build

runtime: fix netbsd build
I've placed net.runtime_Semacquire into netpoll.goc,
but netbsd does not yet use netpoll.goc.

[dvyukov, 2013-08-09 18:11:30]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[bradfitz, 2013-08-09 18:13:25]

LGTM
On Aug 9, 2013 11:11 AM, <dvyukov@google.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
>
https://dvyukov%40google.com@**code.google.com/p/go/<http://40google.com@code...
>
>
> Description:
> runtime: fix openbsd build
> I've placed net.runtime_Semacquire into netpoll.goc,
> but openbsd does not yet use netpoll.goc.
>
> Please review this at
https://codereview.appspot.**com/12699045/<https://codereview.appspot.com/126...
>
> Affected files:
>   M src/pkg/runtime/netpoll.goc
>   M src/pkg/runtime/sema.goc
>
>
> Index: src/pkg/runtime/netpoll.goc
> ==============================**==============================**=======
> --- a/src/pkg/runtime/netpoll.goc
> +++ b/src/pkg/runtime/netpoll.goc
> @@ -206,14 +206,6 @@
>                 runtime·ready(wg);
>  }
>
> -func runtime_Semacquire(addr *uint32) {
> -       runtime·semacquire(addr, true);
> -}
> -
> -func runtime_Semrelease(addr *uint32) {
> -       runtime·semrelease(addr);
> -}
> -
>  uintptr
>  runtime·netpollfd(PollDesc *pd)
>  {
> Index: src/pkg/runtime/sema.goc
> ==============================**==============================**=======
> --- a/src/pkg/runtime/sema.goc
> +++ b/src/pkg/runtime/sema.goc
> @@ -182,6 +182,17 @@
>         }
>  }
>
> +
> +void net·runtime_Semacquire(uint32 *addr)
> +{
> +       runtime·semacquire(addr, true);
> +}
> +
> +void net·runtime_Semrelease(uint32 *addr)
> +{
> +       runtime·semrelease(addr);
> +}
> +
>  func runtime_Semacquire(addr *uint32) {
>         runtime·semacquire(addr, true);
>  }
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[iant, 2013-08-09 18:13:55]

LGTM

But now you've defeated the point of the runtime refactoring.

On Fri, Aug 9, 2013 at 11:13 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> LGTM
>
> On Aug 9, 2013 11:11 AM, <dvyukov@google.com> wrote:
>>
>> Reviewers: golang-dev1,
>>
>> Message:
>> Hello golang-dev@googlegroups.com,
>>
>> I'd like you to review this change to
>> https://dvyukov%40google.com@code.google.com/p/go/
>>
>>
>> Description:
>> runtime: fix openbsd build
>> I've placed net.runtime_Semacquire into netpoll.goc,
>> but openbsd does not yet use netpoll.goc.
>>
>> Please review this at https://codereview.appspot.com/12699045/
>>
>> Affected files:
>>   M src/pkg/runtime/netpoll.goc
>>   M src/pkg/runtime/sema.goc
>>
>>
>> Index: src/pkg/runtime/netpoll.goc
>> ===================================================================
>> --- a/src/pkg/runtime/netpoll.goc
>> +++ b/src/pkg/runtime/netpoll.goc
>> @@ -206,14 +206,6 @@
>>                 runtime·ready(wg);
>>  }
>>
>> -func runtime_Semacquire(addr *uint32) {
>> -       runtime·semacquire(addr, true);
>> -}
>> -
>> -func runtime_Semrelease(addr *uint32) {
>> -       runtime·semrelease(addr);
>> -}
>> -
>>  uintptr
>>  runtime·netpollfd(PollDesc *pd)
>>  {
>> Index: src/pkg/runtime/sema.goc
>> ===================================================================
>> --- a/src/pkg/runtime/sema.goc
>> +++ b/src/pkg/runtime/sema.goc
>> @@ -182,6 +182,17 @@
>>         }
>>  }
>>
>> +
>> +void net·runtime_Semacquire(uint32 *addr)
>> +{
>> +       runtime·semacquire(addr, true);
>> +}
>> +
>> +void net·runtime_Semrelease(uint32 *addr)
>> +{
>> +       runtime·semrelease(addr);
>> +}
>> +
>>  func runtime_Semacquire(addr *uint32) {
>>         runtime·semacquire(addr, true);
>>  }
>>
>>
>> --
>>
>> ---You received this message because you are subscribed to the Google
>> Groups "golang-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-dev+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

[dvyukov, 2013-08-09 18:16:23]

On Fri, Aug 9, 2013 at 10:13 PM, Ian Lance Taylor <iant@golang.org> wrote:
> LGTM
>
> But now you've defeated the point of the runtime refactoring.

Yup...

There is work in progress to use netpoll on all OSes, so hopefully we
will be able to move it back. I will add a TODO.

[dvyukov, 2013-08-09 18:17:15]

*** Submitted as https://code.google.com/p/go/source/detail?r=4961e85603a2 ***

runtime: fix netbsd build
I've placed net.runtime_Semacquire into netpoll.goc,
but netbsd does not yet use netpoll.goc.

R=golang-dev, bradfitz, iant
CC=golang-dev
https://codereview.appspot.com/12699045