Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(608)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 12698045: oauth issue 86: Remove Beta API deprecated in 1.16 [backwards incompatible] (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by yanivi
Modified:
10 years, 8 months ago
Reviewers:
ngmiceli
CC:
peleyal
Base URL:
https://code.google.com/p/google-oauth-java-client/
Visibility:
Public.

Description

oauth issue 86: Remove Beta API deprecated in 1.16 [backwards incompatible]

Patch Set 1 #

Patch Set 2 : without rm google-oauth-client-assembly/dependencies/google-oauth-client-java7-dependencies.html #

Patch Set 3 : fix clirr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1571 lines) Patch
M clirr-ignored-differences.xml View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M google-oauth-client-appengine/src/main/java/com/google/api/client/extensions/appengine/auth/oauth2/AppEngineCredentialStore.java View 1 chunk +1 line, -1 line 0 comments Download
M google-oauth-client-assembly/classpath-include View 1 chunk +0 lines, -1 line 0 comments Download
R google-oauth-client-assembly/dependencies/google-oauth-client-java7-dependencies.html View 2 1 chunk +0 lines, -96 lines 0 comments Download
M google-oauth-client-assembly/pom.xml View 1 chunk +0 lines, -4 lines 0 comments Download
M google-oauth-client-assembly/readme.html View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M google-oauth-client-java6/src/main/java/com/google/api/client/extensions/java6/auth/oauth2/FileCredentialStore.java View 1 chunk +1 line, -1 line 0 comments Download
M google-oauth-client-java6/src/main/java/com/google/api/client/extensions/java6/auth/oauth2/FilePersistedCredential.java View 1 chunk +1 line, -1 line 0 comments Download
M google-oauth-client-java6/src/main/java/com/google/api/client/extensions/java6/auth/oauth2/FilePersistedCredentials.java View 1 chunk +1 line, -1 line 0 comments Download
R google-oauth-client-java7/.classpath View 1 chunk +0 lines, -8 lines 0 comments Download
R google-oauth-client-java7/.project View 1 chunk +0 lines, -17 lines 0 comments Download
R google-oauth-client-java7/.settings/org.eclipse.jdt.core.prefs View 1 chunk +0 lines, -379 lines 0 comments Download
R google-oauth-client-java7/.settings/org.eclipse.jdt.ui.prefs View 1 chunk +0 lines, -119 lines 0 comments Download
R google-oauth-client-java7/pom.xml View 1 chunk +0 lines, -91 lines 0 comments Download
R google-oauth-client-java7/src/main/java/com/google/api/client/extensions/java7/auth/oauth2/FileCredentialStoreJava7.java View 1 chunk +0 lines, -57 lines 0 comments Download
R google-oauth-client-java7/src/main/java/com/google/api/client/extensions/java7/auth/oauth2/package-info.java View 1 chunk +0 lines, -23 lines 0 comments Download
R google-oauth-client-java7/src/test/java/com/google/api/client/extensions/java7/auth/oauth2/FileCredentialStoreJava7Test.java View 1 chunk +0 lines, -202 lines 0 comments Download
M google-oauth-client-servlet/.classpath View 1 chunk +0 lines, -1 line 0 comments Download
R google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/jdo/auth/oauth2/JdoCredentialStore.java View 1 chunk +0 lines, -161 lines 0 comments Download
R google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/jdo/auth/oauth2/JdoPersistedCredential.java View 1 chunk +0 lines, -99 lines 0 comments Download
R google-oauth-client-servlet/src/main/java/com/google/api/client/extensions/jdo/auth/oauth2/package-info.java View 1 chunk +0 lines, -30 lines 0 comments Download
R google-oauth-client-servlet/src/test/java/com/google/api/client/extensions/jdo/auth/oauth2/JdoCredentialStoreTest.java View 1 chunk +0 lines, -120 lines 0 comments Download
M google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/AuthorizationCodeFlow.java View 3 chunks +3 lines, -3 lines 0 comments Download
M google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/CredentialStore.java View 1 chunk +1 line, -1 line 0 comments Download
M google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/CredentialStoreRefreshListener.java View 1 chunk +1 line, -1 line 0 comments Download
R google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/MemoryCredentialStore.java View 1 chunk +0 lines, -81 lines 0 comments Download
R google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/MemoryPersistedCredential.java View 1 chunk +0 lines, -60 lines 0 comments Download
M pom.xml View 3 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 5
yanivi
10 years, 9 months ago (2013-08-09 18:38:25 UTC) #1
ngmiceli
Getting a merge conflict: 1 out of 1 hunks FAILED -- saving rejects to file ...
10 years, 8 months ago (2013-08-12 17:33:16 UTC) #2
yanivi
Done. For whatever reason this command: hg rm google-oauth-client-assembly/dependencies/google-oauth-client-java7-dependencies.html causes the patch to fail. so ...
10 years, 8 months ago (2013-08-12 18:22:25 UTC) #3
ngmiceli
LGTM but please update clirr ignored differences before committing
10 years, 8 months ago (2013-08-16 15:34:15 UTC) #4
yanivi
10 years, 8 months ago (2013-08-16 18:20:58 UTC) #5 
On 2013/08/16 15:34:15, ngmiceli wrote:
> LGTM but please update clirr ignored differences before committing

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b