LGTM On Aug 9, 2013 6:33 AM, <iant@golang.org> wrote: > Reviewers: golang-dev1, > > Message: ...
11 years, 10 months ago
(2013-08-09 15:03:28 UTC)
#2
LGTM
On Aug 9, 2013 6:33 AM, <iant@golang.org> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> test: update bug086.go for current gccgo behaviour
>
> bug086.go:14:1: error: missing return at end of function
>
> Please review this at
https://codereview.appspot.**com/12697043/<https://codereview.appspot.com/126...
>
> Affected files:
> M test/fixedbugs/bug086.go
>
>
> Index: test/fixedbugs/bug086.go
> ==============================**==============================**=======
> --- a/test/fixedbugs/bug086.go
> +++ b/test/fixedbugs/bug086.go
> @@ -6,12 +6,12 @@
>
> package main
>
> -func f() int { // GCCGO_ERROR "control"
> +func f() int {
> if false {
> return 0;
> }
> // we should not be able to return successfully w/o a return
> statement
> -} // GC_ERROR "return"
> +} // ERROR "return"
>
> func main() {
> print(f(), "\n");
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
Issue 12697043: code review 12697043: test: update bug086.go for current gccgo behaviour
(Closed)
Created 11 years, 10 months ago by iant
Modified 11 years, 10 months ago
Reviewers:
Base URL:
Comments: 0