Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1811)

Issue 12695043: Pass action info to the signal item_modified (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by ana.balica
Modified:
10 years, 9 months ago
Reviewers:
thomas.j.waldmann
Visibility:
Public.

Description

Send action that modified the item. The receivers will have an easy way to determine what change have occurred.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Simply pass app #

Patch Set 3 : Send meta and content before destruction #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M MoinMoin/items/__init__.py View 1 2 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 4
Thomas.J.Waldmann
there wasn't much to review. was some file missing? https://codereview.appspot.com/12695043/diff/1/MoinMoin/items/__init__.py File MoinMoin/items/__init__.py (right): https://codereview.appspot.com/12695043/diff/1/MoinMoin/items/__init__.py#newcode398 MoinMoin/items/__init__.py:398: ...
10 years, 9 months ago (2013-08-09 11:56:31 UTC) #1
ana.balica
https://codereview.appspot.com/12695043/diff/1/MoinMoin/items/__init__.py File MoinMoin/items/__init__.py (right): https://codereview.appspot.com/12695043/diff/1/MoinMoin/items/__init__.py#newcode398 MoinMoin/items/__init__.py:398: item_modified.send(app._get_current_object(), item_name=self.name, action=action) On 2013/08/09 11:56:32, Thomas.J.Waldmann wrote: > ...
10 years, 9 months ago (2013-08-09 12:05:11 UTC) #2
Thomas.J.Waldmann
https://codereview.appspot.com/12695043/diff/1/MoinMoin/items/__init__.py File MoinMoin/items/__init__.py (right): https://codereview.appspot.com/12695043/diff/1/MoinMoin/items/__init__.py#newcode398 MoinMoin/items/__init__.py:398: item_modified.send(app._get_current_object(), item_name=self.name, action=action) so you now verified that "app" ...
10 years, 9 months ago (2013-08-10 16:37:43 UTC) #3
Thomas.J.Waldmann
10 years, 9 months ago (2013-08-12 10:30:36 UTC) #4
ok
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b