Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(176)

Issue 12694048: code review 12694048: encoding/binary: fast path for reading slices (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by r
Modified:
4 years, 3 months ago
Reviewers:
bradfitz
CC:
golang-dev
Visibility:
Public.

Description

encoding/binary: fast path for reading slices Again, it still allocates but the code is simple. benchmark old ns/op new ns/op delta BenchmarkReadSlice1000Int32s 35580 11465 -67.78% benchmark old MB/s new MB/s speedup BenchmarkReadSlice1000Int32s 112.42 348.86 3.10x

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r 6eaeab5759f0 https://code.google.com/p/go/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -15 lines) Patch
M src/pkg/encoding/binary/binary.go View 1 2 chunks +67 lines, -15 lines 1 comment Download

Messages

Total messages: 4
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
4 years, 3 months ago (2013-08-09 22:07:04 UTC) #1
bradfitz
LGTM https://codereview.appspot.com/12694048/diff/1/src/pkg/encoding/binary/binary.go File src/pkg/encoding/binary/binary.go (right): https://codereview.appspot.com/12694048/diff/1/src/pkg/encoding/binary/binary.go#newcode141 src/pkg/encoding/binary/binary.go:141: if n > 8 { n > len(b) ...
4 years, 3 months ago (2013-08-09 22:24:59 UTC) #2
r
*** Submitted as https://code.google.com/p/go/source/detail?r=04726e184720 *** encoding/binary: fast path for reading slices Again, it still allocates ...
4 years, 3 months ago (2013-08-09 22:40:40 UTC) #3
bradfitz
4 years, 3 months ago (2013-08-09 22:50:04 UTC) #4
Message was sent while issue was closed.
https://codereview.appspot.com/12694048/diff/6001/src/pkg/encoding/binary/bin...
File src/pkg/encoding/binary/binary.go (right):

https://codereview.appspot.com/12694048/diff/6001/src/pkg/encoding/binary/bin...
src/pkg/encoding/binary/binary.go:612: // intDestSize returns the size of the
data required to represent the data when encoded.
this says nothing about 0 meaning unsupported anymore.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4