*** Submitted as https://code.google.com/p/go/source/detail?r=b43545f2d724 *** encoding/binary: document its goals better It's a modest package with ...
12 years, 2 months ago
(2013-08-09 07:08:11 UTC)
#3
these docs can be used to refusing future improvement to this package? I noticed there ...
12 years, 2 months ago
(2013-08-10 07:08:27 UTC)
#5
these docs can be used to refusing future improvement to this package?
I noticed there was a CL to improve encoding/binary, has been refused.
https://codereview.appspot.com/12521043/ (encoding/binary: Reduce memory
allocations and add fast paths for slices )
在 2013年8月9日星期五UTC+8下午2时26分00秒,r...@golang.org写道:
>
> Reviewers: golang-dev1,
>
> Message:
> Hello golan...@googlegroups.com <javascript:>,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> encoding/binary: document its goals better
> It's a modest package with modest goals and limitations.
> Make that clear.
>
> Please review this at https://codereview.appspot.com/12694043/
>
> Affected files:
> M src/pkg/encoding/binary/binary.go
>
>
> Index: src/pkg/encoding/binary/binary.go
> ===================================================================
> --- a/src/pkg/encoding/binary/binary.go
> +++ b/src/pkg/encoding/binary/binary.go
> @@ -2,8 +2,8 @@
> // Use of this source code is governed by a BSD-style
> // license that can be found in the LICENSE file.
>
> -// Package binary implements translation between numbers and byte
> sequences
> -// and encoding and decoding of varints.
> +// Package binary implements simple translation between numbers and byte
> +// sequences and encoding and decoding of varints.
> //
> // Numbers are translated by reading and writing fixed-size values.
> // A fixed-size value is either a fixed-size arithmetic
> @@ -13,6 +13,11 @@
> // Varints are a method of encoding integers using one or more bytes;
> // numbers with smaller absolute value take a smaller number of bytes.
> // For a specification, see
> http://code.google.com/apis/protocolbuffers/docs/encoding.html.
> +//
> +// This package favors simplicity over efficiency. Clients that require
> +// high-performance serialization, especially for large data structures,
> +// should look at more advanced solutions such as the encoding/gob
> +// package or protocol buffers.
> package binary
>
> import (
>
>
>
Issue 12694043: code review 12694043: encoding/binary: document its goals better
(Closed)
Created 12 years, 2 months ago by r
Modified 12 years, 2 months ago
Reviewers: liigo
Base URL:
Comments: 0