Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17)

Issue 12694043: code review 12694043: encoding/binary: document its goals better (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by r
Modified:
11 years, 7 months ago
Reviewers:
dsymonds, liigo
CC:
golang-dev, dsymonds
Visibility:
Public.

Description

encoding/binary: document its goals better It's a modest package with modest goals and limitations. Make that clear.

Patch Set 1 #

Patch Set 2 : diff -r 2deb5fc5f260 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/pkg/encoding/binary/binary.go View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 5
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 7 months ago (2013-08-09 06:26:00 UTC) #1
dsymonds
LGTM
11 years, 7 months ago (2013-08-09 06:30:32 UTC) #2
r
*** Submitted as https://code.google.com/p/go/source/detail?r=b43545f2d724 *** encoding/binary: document its goals better It's a modest package with ...
11 years, 7 months ago (2013-08-09 07:08:11 UTC) #3
liigo
yeah, these docs will be used to refuse future improvement to this package? 在 2013年8月9日星期五UTC+8下午3时08分11秒,r...@golang.org写道: ...
11 years, 7 months ago (2013-08-10 06:48:59 UTC) #4
liigo
11 years, 7 months ago (2013-08-10 07:08:27 UTC) #5
these docs can be used to refusing future improvement to this package?
I noticed there was a CL to improve encoding/binary, has been refused.
https://codereview.appspot.com/12521043/  (encoding/binary: Reduce memory 
allocations and add fast paths for slices )


在 2013年8月9日星期五UTC+8下午2时26分00秒,r...@golang.org写道:
>
> Reviewers: golang-dev1, 
>
> Message: 
> Hello golan...@googlegroups.com <javascript:>, 
>
> I'd like you to review this change to 
> https://code.google.com/p/go/ 
>
>
> Description: 
> encoding/binary: document its goals better 
> It's a modest package with modest goals and limitations. 
> Make that clear. 
>
> Please review this at https://codereview.appspot.com/12694043/ 
>
> Affected files: 
>    M src/pkg/encoding/binary/binary.go 
>
>
> Index: src/pkg/encoding/binary/binary.go 
> =================================================================== 
> --- a/src/pkg/encoding/binary/binary.go 
> +++ b/src/pkg/encoding/binary/binary.go 
> @@ -2,8 +2,8 @@ 
>   // Use of this source code is governed by a BSD-style 
>   // license that can be found in the LICENSE file. 
>
> -// Package binary implements translation between numbers and byte 
> sequences 
> -// and encoding and decoding of varints. 
> +// Package binary implements simple translation between numbers and byte 
> +// sequences and encoding and decoding of varints. 
>   // 
>   // Numbers are translated by reading and writing fixed-size values. 
>   // A fixed-size value is either a fixed-size arithmetic 
> @@ -13,6 +13,11 @@ 
>   // Varints are a method of encoding integers using one or more bytes; 
>   // numbers with smaller absolute value take a smaller number of bytes. 
>   // For a specification, see   
> http://code.google.com/apis/protocolbuffers/docs/encoding.html. 
> +// 
> +// This package favors simplicity over efficiency. Clients that require 
> +// high-performance serialization, especially for large data structures, 
> +// should look at more advanced solutions such as the encoding/gob 
> +// package or protocol buffers. 
>   package binary 
>
>   import ( 
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b