Issue 12692043: code review 12692043: cmd/cc: use a temporary bitmap when constructing pointe...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12692043: code review 12692043: cmd/cc: use a temporary bitmap when constructing pointe... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by cshapiro1

Modified:
11 years, 10 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/cc: use a temporary bitmap when constructing pointer maps This change makes the way cc constructs pointer maps closer to what gc does and is being done in preparation for changes to the internal content of the pointer map such as a change to distinguish interface pointers from ordinary pointers.

Patch Set 1 #

Patch Set 2 : diff -r b38fdb6c22c1 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b38fdb6c22c1 https://code.google.com/p/go/ #

Total comments: 4

Patch Set 4 : diff -r b38fdb6c22c1 https://code.google.com/p/go/ #

Patch Set 5 : diff -r e87b031b694b https://code.google.com/p/go/ #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -67 lines)			Patch
A	src/cmd/cc/bv.c	View	1	1 chunk	+46 lines, -0 lines	0 comments	Download
M	src/cmd/cc/cc.h	View	1	3 chunks	+13 lines, -0 lines	0 comments	Download
M	src/cmd/cc/pgen.c	View	1 2 3	6 chunks	+52 lines, -67 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

cshapiro1

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 10 months ago (2013-08-09 01:47:29 UTC) #1

rsc

LGTM https://codereview.appspot.com/12692043/diff/6001/src/cmd/cc/pgen.c File src/cmd/cc/pgen.c (right): https://codereview.appspot.com/12692043/diff/6001/src/cmd/cc/pgen.c#newcode652 src/cmd/cc/pgen.c:652: walktype1(Type *type, int32 offset, Bvec *bv) Please s/type/t/ ...

11 years, 10 months ago (2013-08-09 02:44:05 UTC) #2

cshapiro1

https://codereview.appspot.com/12692043/diff/6001/src/cmd/cc/pgen.c File src/cmd/cc/pgen.c (right): https://codereview.appspot.com/12692043/diff/6001/src/cmd/cc/pgen.c#newcode652 src/cmd/cc/pgen.c:652: walktype1(Type *type, int32 offset, Bvec *bv) On 2013/08/09 02:44:05, ...

11 years, 10 months ago (2013-08-09 18:04:52 UTC) #3

cshapiro1

11 years, 10 months ago (2013-08-09 20:02:36 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=f935172343b9 ***

cmd/cc: use a temporary bitmap when constructing pointer maps

This change makes the way cc constructs pointer maps closer to
what gc does and is being done in preparation for changes to
the internal content of the pointer map such as a change to
distinguish interface pointers from ordinary pointers.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/12692043

Expand All Messages | Collapse All Messages