code review 12688044: bufio: make it clear that the client must call Writer.Flush

bufio: make it clear that the client must call Writer.Flush

Fixes issue 5530.

[r, 2013-08-09 05:37:26]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[iant, 2013-08-09 13:41:59]

LGTM

[liigo, 2013-08-10 07:14:40]

"should" or "must" call Writer.Flush ?

在 2013年8月9日星期五UTC+8下午1时37分26秒，r...@golang.org写道：
>
> Reviewers: golang-dev1, 
>
> Message: 
> Hello golan...@googlegroups.com <javascript:>, 
>
> I'd like you to review this change to 
> https://code.google.com/p/go/ 
>
>
> Description: 
> bufio: make it clear that the client must call Writer.Flush 
>
> Fixes issue 5530. 
>
> Please review this at https://codereview.appspot.com/12688044/ 
>
> Affected files: 
>    M src/pkg/bufio/bufio.go 
>
>
> Index: src/pkg/bufio/bufio.go 
> =================================================================== 
> --- a/src/pkg/bufio/bufio.go 
> +++ b/src/pkg/bufio/bufio.go 
> @@ -472,6 +472,9 @@ 
>   // Writer implements buffering for an io.Writer object. 
>   // If an error occurs writing to a Writer, no more data will be 
>   // accepted and all subsequent writes will return the error. 
> +// After all data has been written, the client should call the 
> +// Flush method to guarantee all data has been forwarded to 
> +// the underlying io.Writer. 
>   type Writer struct { 
>           err     error 
>           buf     []byte // either nil or []byte of length bufSize 
>
>
>

[r, 2013-08-12 02:55:41]

*** Submitted as https://code.google.com/p/go/source/detail?r=00a411da5f5a ***

bufio: make it clear that the client must call Writer.Flush

Fixes issue 5530.

R=golang-dev, iant, com.liigo
CC=golang-dev
https://codereview.appspot.com/12688044