https://codereview.appspot.com/12681044/diff/6001/src/pkg/encoding/gob/doc.go File src/pkg/encoding/gob/doc.go (right): https://codereview.appspot.com/12681044/diff/6001/src/pkg/encoding/gob/doc.go#newcode87 src/pkg/encoding/gob/doc.go:87: by calling the corresponding method, again in that order ...
10 years, 4 months ago
(2013-08-10 21:53:34 UTC)
#2
PTAL https://codereview.appspot.com/12681044/diff/6001/src/pkg/encoding/gob/doc.go File src/pkg/encoding/gob/doc.go (right): https://codereview.appspot.com/12681044/diff/6001/src/pkg/encoding/gob/doc.go#newcode87 src/pkg/encoding/gob/doc.go:87: by calling the corresponding method, again in that ...
10 years, 3 months ago
(2013-08-13 14:24:37 UTC)
#3
PTAL
https://codereview.appspot.com/12681044/diff/6001/src/pkg/encoding/gob/doc.go
File src/pkg/encoding/gob/doc.go (right):
https://codereview.appspot.com/12681044/diff/6001/src/pkg/encoding/gob/doc.go...
src/pkg/encoding/gob/doc.go:87: by calling the corresponding method, again in
that order of preference.
On 2013/08/10 21:53:35, r wrote:
> minor point but these comments are formatted to a narrower line length than
the
> others
godoc will reflow them in both text and html mode. i ran |9 fmt -l 80
https://codereview.appspot.com/12681044/diff/6001/src/pkg/encoding/gob/type.go
File src/pkg/encoding/gob/type.go (right):
https://codereview.appspot.com/12681044/diff/6001/src/pkg/encoding/gob/type.g...
src/pkg/encoding/gob/type.go:31: encIndir int8 // number of
indirections to reach the receiver type; may be negative
On 2013/08/10 21:53:35, r wrote:
> with six booleans and the usage pattern i see, i suggest making these bits in
a
> pair of words accessed by methods. you can then have one method per enc/dec,
> something like
>
> func (ut *userTypeInfo) externallyEncoded() bool {
> return ut.externalEncoders != 0
> }
>
> plus
>
> const (
> isGobEncoder = 1 << iota
> isBinaryMarshaler
> isTextMarshaler
> )
>
> and the obvious getters. i don't think you need the setters.
Done.
*** Submitted as https://code.google.com/p/go/source/detail?r=730fafd3bf98 *** encoding/gob: support new generic interfaces in package encoding R=r CC=golang-dev ...
10 years, 3 months ago
(2013-08-14 04:18:52 UTC)
#5
Issue 12681044: code review 12681044: encoding/gob: support new generic interfaces in package...
(Closed)
Created 10 years, 4 months ago by rsc
Modified 10 years, 3 months ago
Reviewers:
Base URL:
Comments: 4