Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(263)

Issue 12681044: code review 12681044: encoding/gob: support new generic interfaces in package... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by rsc
Modified:
4 years, 3 months ago
Reviewers:
r
CC:
r, golang-dev
Visibility:
Public.

Description

encoding/gob: support new generic interfaces in package encoding

Patch Set 1 #

Patch Set 2 : diff -r e052a6dba066 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b1c9e72c2ca3 https://code.google.com/p/go/ #

Total comments: 4

Patch Set 4 : diff -r df2050eeba3a https://code.google.com/p/go/ #

Patch Set 5 : diff -r 00b5a40ae411 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -73 lines) Patch
M src/pkg/encoding/gob/debug.go View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/pkg/encoding/gob/decode.go View 1 2 3 8 chunks +27 lines, -13 lines 0 comments Download
M src/pkg/encoding/gob/doc.go View 1 2 3 1 chunk +20 lines, -11 lines 0 comments Download
M src/pkg/encoding/gob/encode.go View 1 2 3 6 chunks +20 lines, -9 lines 0 comments Download
M src/pkg/encoding/gob/encoder.go View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/encoding/gob/gobencdec_test.go View 1 14 chunks +126 lines, -18 lines 0 comments Download
M src/pkg/encoding/gob/type.go View 1 2 3 8 chunks +61 lines, -20 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
4 years, 3 months ago (2013-08-09 18:00:45 UTC) #1
r
https://codereview.appspot.com/12681044/diff/6001/src/pkg/encoding/gob/doc.go File src/pkg/encoding/gob/doc.go (right): https://codereview.appspot.com/12681044/diff/6001/src/pkg/encoding/gob/doc.go#newcode87 src/pkg/encoding/gob/doc.go:87: by calling the corresponding method, again in that order ...
4 years, 3 months ago (2013-08-10 21:53:34 UTC) #2
rsc
PTAL https://codereview.appspot.com/12681044/diff/6001/src/pkg/encoding/gob/doc.go File src/pkg/encoding/gob/doc.go (right): https://codereview.appspot.com/12681044/diff/6001/src/pkg/encoding/gob/doc.go#newcode87 src/pkg/encoding/gob/doc.go:87: by calling the corresponding method, again in that ...
4 years, 3 months ago (2013-08-13 14:24:37 UTC) #3
r
LGTM
4 years, 3 months ago (2013-08-13 22:29:32 UTC) #4
rsc
4 years, 3 months ago (2013-08-14 04:18:52 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=730fafd3bf98 ***

encoding/gob: support new generic interfaces in package encoding

R=r
CC=golang-dev
https://codereview.appspot.com/12681044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4