Issue 12678043: code review 12678043: cmd/api: show output of api tool even if exit status is 0

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12678043: code review 12678043: cmd/api: show output of api tool even if exit status is 0 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by bradfitz

Modified:
11 years, 7 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/api: show output of api tool even if exit status is 0 We weren't seeing additions. (stuff to put in next.txt)

Patch Set 1 #

Patch Set 2 : diff -r 4a2be1c8942f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4a2be1c8942f https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4a2be1c8942f https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 4a2be1c8942f https://go.googlecode.com/hg/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/cmd/api/run.go	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 7 months ago (2013-08-08 20:28:50 UTC) #1

rsc

LGTM Did this change recently? I was seeing additions a week or two ago.

11 years, 7 months ago (2013-08-08 20:35:27 UTC) #2

bradfitz

It's been changing a lot. On Thu, Aug 8, 2013 at 1:35 PM, Russ Cox ...

11 years, 7 months ago (2013-08-08 20:35:57 UTC) #3

bradfitz

11 years, 7 months ago (2013-08-08 20:36:25 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=ba1c4231613a ***

cmd/api: show output of api tool even if exit status is 0

We weren't seeing additions. (stuff to put in next.txt)

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/12678043

Expand All Messages | Collapse All Messages