code review 12670046: freetype: respect the ROUND_XY_TO_GRID compound glyph flag.

freetype: respect the ROUND_XY_TO_GRID compound glyph flag.

Also add a test that freetype-go derives the same glyph points as
the C freetype implementation.

[nigeltao, 2013-08-11 05:15:27]

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/freetype-go

[bsiegert, 2013-08-11 12:54:08]

https://codereview.appspot.com/12670046/diff/9001/cmd/print-glyph-points/main.c
File cmd/print-glyph-points/main.c (right):

https://codereview.appspot.com/12670046/diff/9001/cmd/print-glyph-points/main...
cmd/print-glyph-points/main.c:37: printf("FT_Load_Glyph: error #%d\n", error);
Mention i in the error message.

https://codereview.appspot.com/12670046/diff/9001/cmd/print-glyph-points/main...
cmd/print-glyph-points/main.c:41: printf("glyph format is not
FT_GLYPH_FORMAT_OUTLINE\n");
ditto

https://codereview.appspot.com/12670046/diff/9001/freetype/truetype/truetype_...
File freetype/truetype/truetype_test.go (right):

https://codereview.appspot.com/12670046/diff/9001/freetype/truetype/truetype_...
freetype/truetype/truetype_test.go:135: // TODO.
You have the output file, so you should be able to write this test, no?

[nigeltao, 2013-08-11 22:58:39]

https://codereview.appspot.com/12670046/diff/9001/cmd/print-glyph-points/main.c
File cmd/print-glyph-points/main.c (right):

https://codereview.appspot.com/12670046/diff/9001/cmd/print-glyph-points/main...
cmd/print-glyph-points/main.c:37: printf("FT_Load_Glyph: error #%d\n", error);
On 2013/08/11 12:54:09, bsiegert wrote:
> Mention i in the error message.

Done.

https://codereview.appspot.com/12670046/diff/9001/cmd/print-glyph-points/main...
cmd/print-glyph-points/main.c:41: printf("glyph format is not
FT_GLYPH_FORMAT_OUTLINE\n");
On 2013/08/11 12:54:09, bsiegert wrote:
> ditto

Done.

https://codereview.appspot.com/12670046/diff/9001/freetype/truetype/truetype_...
File freetype/truetype/truetype_test.go (right):

https://codereview.appspot.com/12670046/diff/9001/freetype/truetype/truetype_...
freetype/truetype/truetype_test.go:135: // TODO.
On 2013/08/11 12:54:09, bsiegert wrote:
> You have the output file, so you should be able to write this test, no?

Hinting doesn't fully work yet, so I can't write this test yet.

[bsiegert, 2013-08-12 06:57:57]

LGTM


> https://codereview.appspot.**com/12670046/diff/9001/**
>
freetype/truetype/truetype_**test.go<https://codereview.appspot.com/12670046/diff/9001/freetype/truetype/truetype_test.go>
> File freetype/truetype/truetype_**test.go (right):
>
> https://codereview.appspot.**com/12670046/diff/9001/**
>
freetype/truetype/truetype_**test.go#newcode135<https://codereview.appspot.com/12670046/diff/9001/freetype/truetype/truetype_test.go#newcode135>
> freetype/truetype/truetype_**test.go:135: // TODO.
> On 2013/08/11 12:54:09, bsiegert wrote:
>
>> You have the output file, so you should be able to write this test,
>>
> no?
>
> Hinting doesn't fully work yet, so I can't write this test yet.


OK, I misunderstood.


>
>
https://codereview.appspot.**com/12670046/<https://codereview.appspot.com/126...
>


-- 
The first essential in chemistry is that you should perform practical work
and conduct experiments, for he who performs not practical work nor makes
experiments will never attain the least degree of mastery.
        -- Abu Musa Jabir ibn Hayyan (721-815)

[nigeltao, 2013-08-13 11:09:19]

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=38e23dc4a845 ***

freetype: respect the ROUND_XY_TO_GRID compound glyph flag.

Also add a test that freetype-go derives the same glyph points as
the C freetype implementation.

R=bsiegert
CC=golang-dev
https://codereview.appspot.com/12670046