Issue 12670044: code review 12670044: net: move InvalidAddrError type into net.go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12670044: code review 12670044: net: move InvalidAddrError type into net.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by mikio

Modified:
11 years, 7 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

net: move InvalidAddrError type into net.go Probably we should remove this type before Go 1 contract has settled, but too late. Instead, keep InvalidAddrError close to package generic error types.

Patch Set 1 #

Patch Set 2 : diff -r d70c9a6579ca https://code.google.com/p/go #

Patch Set 3 : diff -r d70c9a6579ca https://code.google.com/p/go #

Patch Set 4 : diff -r 71a0d736fbbc https://code.google.com/p/go #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	src/pkg/net/ipsock.go	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
	M	src/pkg/net/net.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 7 months ago (2013-08-10 00:24:02 UTC) #1

mikio

11 years, 7 months ago (2013-08-10 00:46:31 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=616e50ded906 ***

net: move InvalidAddrError type into net.go

Probably we should remove this type before Go 1 contract has settled,
but too late. Instead, keep InvalidAddrError close to package generic
error types.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/12670044

Expand All Messages | Collapse All Messages