code review 126700043: go.tools/dashboard: fix integration test

go.tools/dashboard: fix integration test

[adg, 2014-08-26 05:04:36]

Any idea why the /buildtest integration tests are broken? Or how they got that
way?

This change unbreaks them but then they break again toward the end. Did this
ever work? :-/

[dvyukov, 2014-08-26 05:10:39]

https://codereview.appspot.com/126700043/diff/20001/dashboard/app/build/test.go
File dashboard/app/build/test.go (left):

https://codereview.appspot.com/126700043/diff/20001/dashboard/app/build/test....
dashboard/app/build/test.go:147: {"/todo", url.Values{"kind":
{"build-go-commit", "benchmark-go-commit"}, "builder": {"linux-amd64"}}, nil,
&Todo{Kind: "build-go-commit", Data: &Commit{Hash: "0001"}}},
Is it malformed request? Or reply is wrong? What is the reply?

[adg, 2014-08-26 05:17:59]

https://codereview.appspot.com/126700043/diff/20001/dashboard/app/build/test.go
File dashboard/app/build/test.go (left):

https://codereview.appspot.com/126700043/diff/20001/dashboard/app/build/test....
dashboard/app/build/test.go:147: {"/todo", url.Values{"kind":
{"build-go-commit", "benchmark-go-commit"}, "builder": {"linux-amd64"}}, nil,
&Todo{Kind: "build-go-commit", Data: &Commit{Hash: "0001"}}},
On 2014/08/26 05:10:39, dvyukov wrote:
> Is it malformed request? Or reply is wrong? What is the reply?

The reply is "build-go-commit"/"0005" because there are sub-repos revisions to
build at tip, and the expected "build-go-commit"/"0001" won't happen because it
was already filled in on line 89.

Maybe *I* broke this part. :-/

https://codereview.appspot.com/126700043/diff/20001/dashboard/app/build/test.go
File dashboard/app/build/test.go (right):

https://codereview.appspot.com/126700043/diff/20001/dashboard/app/build/test....
dashboard/app/build/test.go:218: {"/todo", url.Values{"kind":
{"build-go-commit", "benchmark-go-commit"}, "builder": {"linux-386"}}, nil,
&Todo{Kind: "benchmark-go-commit", Data: &Commit{Hash: "0003"}}},
Now it fails here with: hashes don't match: got "0001", want "0003"

[dvyukov, 2014-08-26 05:31:15]

https://codereview.appspot.com/126700043/diff/20001/dashboard/app/build/test.go
File dashboard/app/build/test.go (left):

https://codereview.appspot.com/126700043/diff/20001/dashboard/app/build/test....
dashboard/app/build/test.go:147: {"/todo", url.Values{"kind":
{"build-go-commit", "benchmark-go-commit"}, "builder": {"linux-amd64"}}, nil,
&Todo{Kind: "build-go-commit", Data: &Commit{Hash: "0001"}}},
On 2014/08/26 05:17:59, adg wrote:
> On 2014/08/26 05:10:39, dvyukov wrote:
> > Is it malformed request? Or reply is wrong? What is the reply?
> 
> The reply is "build-go-commit"/"0005" because there are sub-repos revisions to
> build at tip, and the expected "build-go-commit"/"0001" won't happen because
it
> was already filled in on line 89.
> 
> Maybe *I* broke this part. :-/

Acknowledged.

https://codereview.appspot.com/126700043/diff/20001/dashboard/app/build/test.go
File dashboard/app/build/test.go (right):

https://codereview.appspot.com/126700043/diff/20001/dashboard/app/build/test....
dashboard/app/build/test.go:218: {"/todo", url.Values{"kind":
{"build-go-commit", "benchmark-go-commit"}, "builder": {"linux-386"}}, nil,
&Todo{Kind: "benchmark-go-commit", Data: &Commit{Hash: "0003"}}},
On 2014/08/26 05:17:59, adg wrote:
> Now it fails here with: hashes don't match: got "0001", want "0003"

I've changed perf todo commit ordering some time ago.
If it's just 7-6-1-3 instead of 7-6-3-1, then it's OK, we just need to update
the test.

[adg, 2014-08-26 05:37:52]

Hello dvyukov@google.com (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.tools

[adg, 2014-08-26 05:38:31]

PTAL

https://codereview.appspot.com/126700043/diff/20001/dashboard/app/build/test.go
File dashboard/app/build/test.go (right):

https://codereview.appspot.com/126700043/diff/20001/dashboard/app/build/test....
dashboard/app/build/test.go:218: {"/todo", url.Values{"kind":
{"build-go-commit", "benchmark-go-commit"}, "builder": {"linux-386"}}, nil,
&Todo{Kind: "benchmark-go-commit", Data: &Commit{Hash: "0003"}}},
On 2014/08/26 05:31:15, dvyukov wrote:
> On 2014/08/26 05:17:59, adg wrote:
> > Now it fails here with: hashes don't match: got "0001", want "0003"
> 
> I've changed perf todo commit ordering some time ago.
> If it's just 7-6-1-3 instead of 7-6-3-1, then it's OK, we just need to update
> the test.

That fixed it.
This CL now fixes the tests.

[dvyukov, 2014-08-26 07:20:53]

LGTM

[adg, 2014-08-26 07:34:32]

*** Submitted as
https://code.google.com/p/go/source/detail?r=1e327df40c14&repo=tools ***

go.tools/dashboard: fix integration test

LGTM=dvyukov
R=dvyukov
CC=golang-codereviews
https://codereview.appspot.com/126700043