code review 126660043: cmd/go: clean up a couple of inconsequential nits in ge...

cmd/go: clean up a couple of inconsequential nits in generate
Post-submit glitches caught by reviewers.

[r, 2014-08-25 19:48:21]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[ioe, 2014-08-25 19:51:11]

LGTM

[bradfitz, 2014-08-25 19:56:56]

LGTM
 On Aug 25, 2014 12:48 PM, <r@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> cmd/go: clean up a couple of inconsequential nits in generate
> Post-submit glitches caught by reviewers.
>
> Please review this at https://codereview.appspot.com/126660043/
>
> Affected files (+1, -2 lines):
>   M src/cmd/go/generate.go
>   M src/cmd/go/generate_test.go
>
>
> Index: src/cmd/go/generate.go
> ===================================================================
> --- a/src/cmd/go/generate.go
> +++ b/src/cmd/go/generate.go
> @@ -161,7 +161,7 @@
>  // run runs the generators in the current file.
>  func (g *Generator) run() (ok bool) {
>         // Processing below here calls g.errorf on failure, which does
> panic(stop).
> -       // If we encouter an error, we abort the package.
> +       // If we encounter an error, we abort the package.
>         defer func() {
>                 e := recover()
>                 if e != nil {
> Index: src/cmd/go/generate_test.go
> ===================================================================
> --- a/src/cmd/go/generate_test.go
> +++ b/src/cmd/go/generate_test.go
> @@ -26,7 +26,6 @@
>         {"$GOPACKAGE", []string{"sys"}},
>         {"a $XXNOTDEFINEDXX b", []string{"a", "", "b"}},
>         {"/$XXNOTDEFINED/", []string{"//"}},
> -       {"$GOARCH", []string{runtime.GOARCH}},
>         {"yacc -o $GOARCH/yacc_$GOFILE", []string{"go", "tool", "yacc",
> "-o", runtime.GOARCH + "/yacc_proc.go"}},
>  }
>
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[r, 2014-08-25 20:47:46]

*** Submitted as https://code.google.com/p/go/source/detail?r=e5c4cb7c286b ***

cmd/go: clean up a couple of inconsequential nits in generate
Post-submit glitches caught by reviewers.

LGTM=nightlyone, bradfitz
R=golang-codereviews, nightlyone, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/126660043

[gobot, 2014-08-25 21:08:50]

This CL appears to have broken the openbsd-386-rootbsd builder.
See http://build.golang.org/log/6e029a2d1de55cca1e858668fc7ed328998c3ac4