Performance testing for subscribers determination

Average time for determining subscribers is 0.022 seconds for 100 subscribed users.

[waldi, 2013-08-11 08:09:08]

https://codereview.appspot.com/12665045/diff/1/MoinMoin/util/_tests/test_subs...
File MoinMoin/util/_tests/test_subscriptions.py (right):

https://codereview.appspot.com/12665045/diff/1/MoinMoin/util/_tests/test_subs...
MoinMoin/util/_tests/test_subscriptions.py:94: for i in xrange(100):
100 is a bit small. It have to scale to a few thousand.

https://codereview.appspot.com/12665045/diff/1/MoinMoin/util/_tests/test_subs...
MoinMoin/util/_tests/test_subscriptions.py:99:
user_.subscribe(*choice(subscriptions))
You want to do one test per subscription type.

[Thomas.J.Waldmann, 2013-08-11 10:36:59]

https://codereview.appspot.com/12665045/diff/1/MoinMoin/util/_tests/test_subs...
File MoinMoin/util/_tests/test_subscriptions.py (right):

https://codereview.appspot.com/12665045/diff/1/MoinMoin/util/_tests/test_subs...
MoinMoin/util/_tests/test_subscriptions.py:94: for i in xrange(100):
On 2013/08/11 08:09:08, waldi wrote:
> 100 is a bit small. It have to scale to a few thousand.

The issues with 1.9 showed up at sites with e.g. 30.000 users IIRC. As we have
an index now, please increase that count to 10.000 at least later, as soon as
the test is that far developped that there are no fundamental issues even
visible at 100.

https://codereview.appspot.com/12665045/diff/1/MoinMoin/util/_tests/test_subs...
MoinMoin/util/_tests/test_subscriptions.py:100: expected_names.add(user_.name0)
maybe all the stuff above should be in test setup and only the stuff below
should be in the test.

for performance estimation, we are mainly interested in get_subscribers, not in
how fast we can create lots of users.

[Thomas.J.Waldmann, 2013-08-11 10:42:41]

https://codereview.appspot.com/12665045/diff/13001/MoinMoin/util/_tests/test_...
File MoinMoin/util/_tests/test_subscriptions.py (right):

https://codereview.appspot.com/12665045/diff/13001/MoinMoin/util/_tests/test_...
MoinMoin/util/_tests/test_subscriptions.py:88: (NAMEPREFIX, u"fo",
NAMESPACE_DEFAULT), ],
you won't be able to see whether both worked this way

https://codereview.appspot.com/12665045/diff/13001/MoinMoin/util/_tests/test_...
MoinMoin/util/_tests/test_subscriptions.py:91: (NAMERE, r"f.+",
NAMESPACE_DEFAULT), ],
same here

https://codereview.appspot.com/12665045/diff/13001/MoinMoin/util/_tests/test_...
MoinMoin/util/_tests/test_subscriptions.py:108: assert subscribers_names ==
expected_names
maybe we should have perf tests per subscr type (to see individual type's perf,
types = id, pattern)

[ana.balica, 2013-08-11 10:51:17]

https://codereview.appspot.com/12665045/diff/1/MoinMoin/util/_tests/test_subs...
File MoinMoin/util/_tests/test_subscriptions.py (right):

https://codereview.appspot.com/12665045/diff/1/MoinMoin/util/_tests/test_subs...
MoinMoin/util/_tests/test_subscriptions.py:100: expected_names.add(user_.name0)
On 2013/08/11 10:36:59, Thomas.J.Waldmann wrote:
> maybe all the stuff above should be in test setup and only the stuff below
> should be in the test.

If we move the creation of 10.000 users in the setup_method, then all the other
tests in test_subscriptions.py will be forced to wait for hours to execute
one-seconds tests.
Is there a way to create a setup method only for one test?

[ana.balica, 2013-08-11 10:59:41]

https://codereview.appspot.com/12665045/diff/13001/MoinMoin/util/_tests/test_...
File MoinMoin/util/_tests/test_subscriptions.py (right):

https://codereview.appspot.com/12665045/diff/13001/MoinMoin/util/_tests/test_...
MoinMoin/util/_tests/test_subscriptions.py:108: assert subscribers_names ==
expected_names
On 2013/08/11 10:42:41, Thomas.J.Waldmann wrote:
> maybe we should have perf tests per subscr type (to see individual type's
perf,
> types = id, pattern)

I have measured the time performance for each subscription type for the current
setup (5.000 subscribers):

ITEMID - 0.467688083649 s
NAME - 0.509696006775 s
TAGS - 0.692392110825 s
2 NAMEPREFIX subscriptions - 0.999751806259 s
3 NAMERE subscriptions - 1.35586810112 s

I will raise the users number to 10.000 and will keep one subscription per type.

[ana.balica, 2013-08-11 15:35:11]

https://codereview.appspot.com/12665045/diff/17002/MoinMoin/util/_tests/test_...
File MoinMoin/util/_tests/test_subscriptions.py (right):

https://codereview.appspot.com/12665045/diff/17002/MoinMoin/util/_tests/test_...
MoinMoin/util/_tests/test_subscriptions.py:102: subscribers =
get_subscribers(self.item)
Time performance results:

ITEMID: 	0.920804023743
NAME:		1.06206607819
TAGS:		1.12728404999
NAMEFREFIX:	1.92953085899
NAMERE:		2.80170202255

[Thomas.J.Waldmann, 2013-08-11 15:56:54]

https://codereview.appspot.com/12665045/diff/23001/MoinMoin/util/_tests/test_...
File MoinMoin/util/_tests/test_subscriptions.py (right):

https://codereview.appspot.com/12665045/diff/23001/MoinMoin/util/_tests/test_...
MoinMoin/util/_tests/test_subscriptions.py:107: print "Execution time:\t{0}
s".format(elapsed_time)
maybe one line for test type and time needed, as you had in your previous
output?

[ana.balica, 2013-08-12 05:17:27]

https://codereview.appspot.com/12665045/diff/28001/MoinMoin/util/_tests/test_...
File MoinMoin/util/_tests/test_subscriptions.py (right):

https://codereview.appspot.com/12665045/diff/28001/MoinMoin/util/_tests/test_...
MoinMoin/util/_tests/test_subscriptions.py:112: subscribers =
get_subscribers(self.item)
Testing 100 subscribers from a total of 10000 users
itemid: 0.0232298374176 s
name: 0.0234529972076 s
tags: 0.0243420600891 s
nameprefix: 0.0237731933594 s
namere: 0.0244739055634 s

Testing 10000 subscribers from a total of 10000 users
itemid: 0.922185897827 s
name: 0.911366939545 s
tags: 0.939110040665 s
nameprefix: 0.84325003624 s
namere: 1.0870051384 s

[ReimarBauer, 2013-08-12 08:35:29]

https://codereview.appspot.com/12665045/diff/28001/MoinMoin/util/_tests/test_...
File MoinMoin/util/_tests/test_subscriptions.py (right):

https://codereview.appspot.com/12665045/diff/28001/MoinMoin/util/_tests/test_...
MoinMoin/util/_tests/test_subscriptions.py:103: import time
why is time imported here?