Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(308)

Issue 12665043: Fix charm functional tests.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by frankban
Modified:
10 years, 8 months ago
Reviewers:
mp+179196
Visibility:
Public.

Description

Fix charm functional tests. Updated Selenium to the last version: it includes a fix for Firefox 23. Also updated the force-machine test: use the new --to juju-core option. https://code.launchpad.net/~frankban/charms/precise/juju-gui/ftests-fixes/+merge/179196 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix charm functional tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M revision View 1 chunk +1 line, -1 line 0 comments Download
M tests/deploy.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/requirements.pip View 1 chunk +1 line, -1 line 0 comments Download
M tests/test_deploy.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
frankban
Please take a look.
10 years, 8 months ago (2013-08-08 13:56:37 UTC) #1
frankban
Self-review: critical + trivial.
10 years, 8 months ago (2013-08-08 13:58:23 UTC) #2
frankban
10 years, 8 months ago (2013-08-08 14:01:56 UTC) #3
*** Submitted:

Fix charm functional tests.

Updated Selenium to the last version: it includes
a fix for Firefox 23.

Also updated the force-machine test: use the new
--to juju-core option.

R=
CC=
https://codereview.appspot.com/12665043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b