Issue 12661043: state/api: Uniter client-side API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12661043: state/api: Uniter client-side API (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by dimitern

Modified:
10 years, 9 months ago

Reviewers:
gz, mp+179176, rog

Visibility:
Public.

Description

state/api: Uniter client-side API This introduces part of the client-side API needed by the uniter worker. There will be a lot more calls in there, but they will be added incrementally. https://code.launchpad.net/~dimitern/juju-core/093-api-uniter/+merge/179176 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : state/api: Uniter client-side API #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+330 lines, -3 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/api/machiner/machiner_test.go	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	state/api/state.go	View	2 chunks	+7 lines, -0 lines	0 comments	Download
A	state/api/uniter/unit.go	View	1 chunk	+88 lines, -0 lines	0 comments	Download
A	state/api/uniter/uniter.go	View	1 chunk	+53 lines, -0 lines	0 comments	Download
A	state/api/uniter/uniter_test.go	View	1 chunk	+165 lines, -0 lines	0 comments	Download
M	state/apiserver/root.go	View	2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

On 2013/08/08 13:09:02, dimitern wrote: > Please take a look. LGTM

10 years, 9 months ago (2013-08-08 13:13:15 UTC) #2

LGTM. The new files are stamped "2012, 2013", but I guess they're based on existing ...

10 years, 9 months ago (2013-08-08 13:40:22 UTC) #3

dimitern

10 years, 9 months ago (2013-08-08 13:42:55 UTC) #4

Please take a look.

https://codereview.appspot.com/12661043/diff/1/state/api/machiner/machiner_te...
File state/api/machiner/machiner_test.go (right):

https://codereview.appspot.com/12661043/diff/1/state/api/machiner/machiner_te...
state/api/machiner/machiner_test.go:19: jc
"launchpad.net/juju-core/testing/checkers"
On 2013/08/08 13:40:22, gz wrote:
> Hm, jc is new to me as a prefix for the checkers, but I guess we're
> standardising on it?

I think so. At least I've seen it in quite a few places already.

Expand All Messages | Collapse All Messages