Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(501)

Issue 12659043: Update and simplify README (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by Michael Nelson
Modified:
10 years, 9 months ago
Reviewers:
dimitern, mp+179165, fwereade, rog
Visibility:
Public.

Description

Update and simplify README Remove obsolete info and simplify remaining info regarding installing dependencies. https://code.launchpad.net/~michael.nelson/juju-core/update-readme/+merge/179165 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Update and simplify README #

Patch Set 3 : Update and simplify README #

Total comments: 8

Patch Set 4 : Update and simplify README #

Total comments: 4

Patch Set 5 : Update and simplify README #

Patch Set 6 : Update and simplify README #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -51 lines) Patch
M Makefile View 1 2 3 4 1 chunk +8 lines, -3 lines 0 comments Download
M README View 1 2 3 4 4 chunks +30 lines, -48 lines 0 comments Download
A [revision details] View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8
Michael Nelson
Please take a look.
10 years, 9 months ago (2013-08-08 11:38:01 UTC) #1
Michael Nelson
Please take a look.
10 years, 9 months ago (2013-08-08 11:39:17 UTC) #2
dimitern
LGTM with a couple of comments. https://codereview.appspot.com/12659043/diff/5001/README File README (left): https://codereview.appspot.com/12659043/diff/5001/README#oldcode68 README:68: http://juju-dist.s3.amazonaws.com/tools/mongo-2.2.0-precise-amd64.tgz I think ...
10 years, 9 months ago (2013-08-08 11:58:05 UTC) #3
rog
I like the motivation, but I'm not entirely sure about the result. Some thoughts below. ...
10 years, 9 months ago (2013-08-08 12:10:00 UTC) #4
Michael Nelson
Please take a look. https://codereview.appspot.com/12659043/diff/5001/README File README (left): https://codereview.appspot.com/12659043/diff/5001/README#oldcode68 README:68: http://juju-dist.s3.amazonaws.com/tools/mongo-2.2.0-precise-amd64.tgz On 2013/08/08 11:58:05, dimitern ...
10 years, 9 months ago (2013-08-08 12:35:51 UTC) #5
rog
LGTM with one suggestion below https://codereview.appspot.com/12659043/diff/10001/README File README (right): https://codereview.appspot.com/12659043/diff/10001/README#newcode104 README:104: provider, as the local ...
10 years, 9 months ago (2013-08-12 12:31:13 UTC) #6
fwereade
just a comment https://codereview.appspot.com/12659043/diff/10001/Makefile File Makefile (right): https://codereview.appspot.com/12659043/diff/10001/Makefile#newcode21 Makefile:21: @sudo apt-add-repository ppa:juju/experimental I think this ...
10 years, 9 months ago (2013-08-13 09:24:44 UTC) #7
Michael Nelson
10 years, 9 months ago (2013-08-13 09:39:36 UTC) #8
Please take a look.

https://codereview.appspot.com/12659043/diff/10001/Makefile
File Makefile (right):

https://codereview.appspot.com/12659043/diff/10001/Makefile#newcode21
Makefile:21: @sudo apt-add-repository ppa:juju/experimental
On 2013/08/13 09:24:44, fwereade wrote:
> I think this should be "stable" now, shouldn't it?

Yes - now that mongodb is there. Updating.

https://codereview.appspot.com/12659043/diff/10001/README
File README (right):

https://codereview.appspot.com/12659043/diff/10001/README#newcode104
README:104: provider, as the local container is created in /var/lib/lxc):
On 2013/08/12 12:31:13, rog wrote:
> (Note: the use of sudo for bootstrap here is only required for the local
> provider because it uses LXC, which requires root privileges)
> 
> ?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b