code review 126570043: cmd/gc: fix order of channel evaluation of receive channels

cmd/gc: fix order of channel evaluation of receive channels

Normally, an expression of the form x.f or *y can be reordered
with function calls and communications.

Select is stricter than normal: each channel expression is evaluated
in source order. If you have case <-x.f and case <-foo(), then if the
evaluation of x.f causes a panic, foo must not have been called.
(This is in contrast to an expression like x.f + foo().)

Enforce this stricter ordering.

Fixes issue 8336.

[rsc, 2014-08-25 02:28:58]

Hello golang-codereviews@googlegroups.com (cc: dvyukov, r),

I'd like you to review this change to
https://code.google.com/p/go/

[dvyukov, 2014-08-25 05:43:44]

LGTM

[rsc, 2014-08-25 11:05:41]

*** Submitted as https://code.google.com/p/go/source/detail?r=c29860623fb3 ***

cmd/gc: fix order of channel evaluation of receive channels

Normally, an expression of the form x.f or *y can be reordered
with function calls and communications.

Select is stricter than normal: each channel expression is evaluated
in source order. If you have case <-x.f and case <-foo(), then if the
evaluation of x.f causes a panic, foo must not have been called.
(This is in contrast to an expression like x.f + foo().)

Enforce this stricter ordering.

Fixes issue 8336.

LGTM=dvyukov
R=golang-codereviews, dvyukov
CC=golang-codereviews, r
https://codereview.appspot.com/126570043