Remove defunct 'es53-' prefix from test names

The tests named "ES53" were named that way a long time ago to distinguish
them from the older, Cajita/Valija system. There is now no need for this
prefix.

[felix8a, 2013-08-08 05:29:22]

were these svn mv'ed?

[ihab.awad, 2013-08-08 05:32:47]

I believe so, yes. I see now they showed up as a bunch of deletions and
additions -- not my intentions at all. :(

-- 
Ihab A.B. Awad, Palo Alto, CA

[felix8a, 2013-08-08 05:34:11]

the adds show diffs from the original version at the old name, so it's not hard
to read on codereview, but it's awkward to download and apply as a patch

[ihab.awad, 2013-08-08 05:37:46]

Hmm ... well, the following diff, for example --

https://codereview.appspot.com/12648043/diff/1/tests/com/google/caja/plugin/t...

shows more than just a renaming. It has no business showing anything else!
Something Is Wrong [TM] and I'm tempted to revert the whole danged thing
and try again. In fact, that's exactly what I'm going to do. Stay tuned.

[felix8a, 2013-08-08 05:42:04]

https://codereview.appspot.com/12648043/diff/1/tests/com/google/caja/plugin/t...
File tests/com/google/caja/plugin/test-css-imports-guest.html (right):

https://codereview.appspot.com/12648043/diff/1/tests/com/google/caja/plugin/t...
tests/com/google/caja/plugin/test-css-imports-guest.html:18: <!-- Low
specificity rule lets us detect un-applied rules. -->
yeah, this is an odd diff. the old version it's comparing against is prior to
r5517, rather than the latest version r5540, so I'm not confident that reading
these added-file diffs is an accurate description of this change.

[kpreid_google, 2013-08-08 05:42:30]

That non-business is a change I recently committed. Wrong base revision?

Also, I suggest renaming test-guest-* to reflect what it actually is,
namely a support file for test-cajajs-invocation. Not a standalone test.
On Aug 7, 2013 10:37 PM, <ihab.awad@gmail.com> wrote:

> Hmm ... well, the following diff, for example --
>
>
>
https://codereview.appspot.com/12648043/diff/1/tests/com/google/caja/plugin/t...
>
> shows more than just a renaming. It has no business showing anything else!
> Something Is Wrong [TM] and I'm tempted to revert the whole danged thing
> and try again. In fact, that's exactly what I'm going to do. Stay tuned.
>

[felix8a, 2013-08-08 05:46:30]

no, it's more confused than that. most of the diff is against the
latest r5540, but the adds are diffs against some earlier version. I
suspect Ihab did like an "svn mv" a while ago and then svn updated to
trunk, but the svn update didn't do anything special with the files
previously svn mv'ed.

On Wed, Aug 7, 2013 at 10:42 PM, Kevin Reid <kpreid@google.com> wrote:
> That non-business is a change I recently committed. Wrong base revision?
>
> Also, I suggest renaming test-guest-* to reflect what it actually is, namely
> a support file for test-cajajs-invocation. Not a standalone test.
>
> On Aug 7, 2013 10:37 PM, <ihab.awad@gmail.com> wrote:
>>
>> Hmm ... well, the following diff, for example --
>>
>>
>>
https://codereview.appspot.com/12648043/diff/1/tests/com/google/caja/plugin/t...
>>
>> shows more than just a renaming. It has no business showing anything else!
>> Something Is Wrong [TM] and I'm tempted to revert the whole danged thing and
>> try again. In fact, that's exactly what I'm going to do. Stay tuned.
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Google Caja Discuss" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-caja-discuss+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

[ihab.awad, 2013-08-08 05:50:36]

On Wed, Aug 7, 2013 at 10:46 PM, felix <felix8a@gmail.com> wrote:

> I suspect Ihab did like an "svn mv" a while ago and then svn updated
> to trunk, but the svn update didn't do anything special with the
> files previously svn mv'ed.
>

I think that's what happened yes. Then I did a diff of each file against
trunk and patched in the changes, but somehow it failed to rebase the files
that were moved in some weird way? I don't know.

-- 
Ihab A.B. Awad, Palo Alto, CA

[ihab.awad, 2013-08-08 15:56:52]

On Wed, Aug 7, 2013 at 10:42 PM, Kevin Reid <kpreid@google.com> wrote:

> Also, I suggest renaming test-guest-* to reflect what it actually is,
> namely a support file for test-cajajs-invocation. Not a standalone test.
>
That mixup galls me too, though I must say it's not strictly within the
purvey of the task to which I have set myself for this CL. It should be
easy enough though. };->

Ihab

-- 
Ihab A.B. Awad, Palo Alto, CA

[ihab.awad, 2013-08-09 23:15:57]

The tests named "ES53" were named that way a long time ago to distinguish
them from the older, Cajita/Valija system. There is now no need for this
prefix.

[ihab.awad, 2013-08-09 23:26:10]

https://codereview.appspot.com/12648043/diff/1/tests/com/google/caja/plugin/t...
File tests/com/google/caja/plugin/test-css-imports-guest.html (right):

https://codereview.appspot.com/12648043/diff/1/tests/com/google/caja/plugin/t...
tests/com/google/caja/plugin/test-css-imports-guest.html:18: <!-- Low
specificity rule lets us detect un-applied rules. -->
On 2013/08/08 05:42:04, felix8a wrote:
> yeah, this is an odd diff. the old version it's comparing against is prior to
> r5517, rather than the latest version r5540, so I'm not confident that reading
> these added-file diffs is an accurate description of this change.

Done.

[felix8a, 2013-08-10 01:04:46]

lgtm

[felix8a, 2013-08-10 01:06:48]

fixture-guest.js seems to be missing from the CL

[felix8a, 2013-08-10 01:07:55]

On 2013/08/10 01:06:48, felix8a wrote:
> fixture-guest.js seems to be missing from the CL

test-cajoled.js is also missing

[ihab.awad, 2013-08-14 03:45:40]

The tests named "ES53" were named that way a long time ago to distinguish
them from the older, Cajita/Valija system. There is now no need for this
prefix.

[ihab.awad, 2013-08-14 03:47:28]

fixture-guest.js and test-cajoled.js are in my CL on my SVN client, I swear. :(

[ihab.awad, 2013-08-14 04:03:45]

ihab-macbookpro2:google-caja ihab$ svn status | grep test-cajoled.js
D       tests/com/google/caja/plugin/es53-test-cajoled.js
A  +    tests/com/google/caja/plugin/test-cajoled.js

ihab-macbookpro2:google-caja ihab$ svn status | grep es53-test-guest.js
D       tests/com/google/caja/plugin/es53-test-guest.js
ihab-macbookpro2:google-caja ihab$ svn status | grep fixture-guest.js
A  +    tests/com/google/caja/plugin/fixture-guest.js

I think my local client is just fine; I think our upload to codereview is
flakey. The tests all pass.

LGTY?

[ihab.awad, 2013-08-14 04:03:48]

ihab-macbookpro2:google-caja ihab$ svn status | grep test-cajoled.js
D       tests/com/google/caja/plugin/es53-test-cajoled.js
A  +    tests/com/google/caja/plugin/test-cajoled.js

ihab-macbookpro2:google-caja ihab$ svn status | grep es53-test-guest.js
D       tests/com/google/caja/plugin/es53-test-guest.js
ihab-macbookpro2:google-caja ihab$ svn status | grep fixture-guest.js
A  +    tests/com/google/caja/plugin/fixture-guest.js

I think my local client is just fine; I think our upload to codereview is
flakey. The tests all pass.

LGTY?

[felix8a, 2013-08-14 04:21:48]

lgtm

[ihab.awad, 2013-08-14 04:29:25]

The tests named "ES53" were named that way a long time ago to distinguish
them from the older, Cajita/Valija system. There is now no need for this
prefix.

[ihab.awad, 2013-08-14 04:57:24]

@5558