Issue 12646043: code review 12646043: reflect: avoid allocation when interface's contents are...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12646043: code review 12646043: reflect: avoid allocation when interface's contents are... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by r

Modified:
11 years, 10 months ago

Reviewers:
rsc, bradfitz

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

reflect: avoid allocation when interface's contents are not addressable See issue 4949 for a full explanation. Allocs go from 1 to zero in the non-addressable case. Fixes issue 4949. BenchmarkInterfaceBig 90 14 -84.01% BenchmarkInterfaceSmall 14 14 +0.00%

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r 9fae1e2e54a1 https://code.google.com/p/go/ #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -1 line)			Patch
	M	src/pkg/reflect/all_test.go	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download
	M	src/pkg/reflect/value.go	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 10 months ago (2013-08-08 03:31:11 UTC) #1

bradfitz

LGTM https://codereview.appspot.com/12646043/diff/1/src/pkg/reflect/all_test.go File src/pkg/reflect/all_test.go (right): https://codereview.appspot.com/12646043/diff/1/src/pkg/reflect/all_test.go#newcode3437 src/pkg/reflect/all_test.go:3437: t.Logf("allocs per run: %g\n", testing.AllocsPerRun(100, func() { v.Interface() ...

11 years, 10 months ago (2013-08-08 20:56:00 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=e7db7a0c79a4 *** reflect: avoid allocation when interface's contents are not addressable See ...

11 years, 10 months ago (2013-08-09 00:49:09 UTC) #3

LGTM

This is consistent with cvtDirect too.

Expand All Messages | Collapse All Messages