Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(944)

Issue 126430044: Debian - Maven build. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by roubert (google)
Modified:
9 years, 8 months ago
Base URL:
https://libphonenumber.googlecode.com/svn/trunk
Visibility:
Public.

Description

Debian - Maven build. This adapts the Debian package to build all the Java tools and the library just using Maven, not using Ant any more. This depends on the patch submitted earlier in the email titled "build the tools and libraries all at once with Maven" Author: daniel@pocock.pro R=jia.shao.peng@gmail.com BUG= Committed: https://code.google.com/p/libphonenumber/source/detail?r=688

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update patches/series with current list of patch files. #

Patch Set 3 : Revert unintentional inclusion of base change. #

Patch Set 4 : Applied more-debian-fixes.patch #

Patch Set 5 : Revert unintentional inclusion of base change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -31 lines) Patch
M debian/control View 1 2 3 3 chunks +27 lines, -15 lines 0 comments Download
A debian/libphonenumber6-java.poms View 1 2 3 1 chunk +39 lines, -0 lines 0 comments Download
A debian/maven.cleanIgnoreRules View 1 chunk +17 lines, -0 lines 0 comments Download
A debian/maven.ignoreRules View 1 chunk +23 lines, -0 lines 0 comments Download
A debian/maven.properties View 1 chunk +4 lines, -0 lines 0 comments Download
A debian/maven.publishedRules View 1 chunk +19 lines, -0 lines 0 comments Download
A debian/maven.rules View 1 chunk +31 lines, -0 lines 0 comments Download
A debian/patches/0003-maven-exclude-demo.patch View 1 chunk +13 lines, -0 lines 0 comments Download
A debian/patches/series View 1 1 chunk +1 line, -0 lines 0 comments Download
M debian/rules View 2 chunks +27 lines, -15 lines 0 comments Download
M debian/source/format View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
roubert (google)
9 years, 8 months ago (2014-08-19 20:46:35 UTC) #1
roubert (google)
https://codereview.appspot.com/126430044/diff/1/debian/patches/series File debian/patches/series (right): https://codereview.appspot.com/126430044/diff/1/debian/patches/series#newcode1 debian/patches/series:1: 0004-unsigned-long-symbol.patch I assume this is supposed to be replaced ...
9 years, 8 months ago (2014-08-19 21:18:13 UTC) #2
daniel2
Please also see my later patch email "additional Debian fixes" which should be committed together ...
9 years, 8 months ago (2014-08-20 17:53:31 UTC) #3
roubert (google)
On 2014/08/20 17:53:31, daniel2 wrote: > Please also see my later patch email "additional Debian ...
9 years, 8 months ago (2014-08-21 15:56:04 UTC) #4
Shaopeng
On 2014/08/21 15:56:04, roubert (google) wrote: > On 2014/08/20 17:53:31, daniel2 wrote: > > Please ...
9 years, 8 months ago (2014-08-22 14:31:33 UTC) #5
roubert (google)
9 years, 8 months ago (2014-08-22 14:44:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 manually as 688 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b