Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 126400043: code review 126400043: liblink: fix encoding of ASETPC in 6a, 8a (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by josharian
Modified:
10 years, 7 months ago
Reviewers:
ruiu, gobot, rsc
CC:
rsc, ruiu, golang-codereviews
Visibility:
Public.

Description

liblink: fix encoding of ASETPC in 6a, 8a It was incorrectly encoded as ASETLS.

Patch Set 1 #

Patch Set 2 : diff -r ff34a3e84dc0b99eaf080eb19decc1f0a1f615a0 https://code.google.com/p/go #

Patch Set 3 : diff -r ff34a3e84dc0b99eaf080eb19decc1f0a1f615a0 https://code.google.com/p/go #

Patch Set 4 : diff -r 5856eae43c269fc32cdf2cfca0c9412ee4a5969c https://code.google.com/p/go #

Patch Set 5 : diff -r d9b3cbdfc09f54349ade880a7549764edebc081f https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/liblink/asm6.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/liblink/asm8.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
josharian
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com, ruiu@google.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 7 months ago (2014-08-18 23:03:52 UTC) #1
ruiu
LGTM Confirmed that 0f 9b is the correct encoding for SETNP (set byte if not ...
10 years, 7 months ago (2014-08-18 23:56:44 UTC) #2
josharian
Thanks, ruiu. Waiting for rsc because of the freeze. > Confirmed that 0f 9b is ...
10 years, 7 months ago (2014-08-19 00:00:54 UTC) #3
rsc
LGTM
10 years, 7 months ago (2014-08-19 00:53:51 UTC) #4
josharian
*** Submitted as https://code.google.com/p/go/source/detail?r=15918878ae51 *** liblink: fix encoding of ASETPC in 6a, 8a It was ...
10 years, 7 months ago (2014-08-19 01:14:58 UTC) #5
gobot
10 years, 7 months ago (2014-08-19 02:21:05 UTC) #6
Message was sent while issue was closed.
This CL appears to have broken the linux-arm-cheney-panda builder.
See http://build.golang.org/log/b366cd9157ca202a9e9be38f4144409075c3e796
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b