Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(130)

Issue 12637043: Add SuppressWarnings annotations to test to suppress static method warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by MikeSamuel
Modified:
12 years, 8 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Eclipse complains about methods that could be static but aren't. JUnit test methods are entry points found by reflection by the test runner so often are non-static even though they could be. This just adds an annotation to each test class that suppresses these bogus warnings. It could be done in Eclipse, but warning filtering is a major PITA and isn't conducive to warning-free builds by someone who is downloading the source for the first time. ---- Submitted @ r5544

Patch Set 1 #

Patch Set 2 : Add SuppressWarnings annotations to test to suppress static method warnings #

Patch Set 3 : Add SuppressWarnings annotations to test to suppress static method warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M tests/com/google/caja/ancillary/linter/ErrorReporterTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/ancillary/linter/ExitModesTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/lang/css/CssPropertyPatternsTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/lang/css/PartitionsTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/lexer/CharProducerTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/lexer/ChardetTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/lexer/CssLexerTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/lexer/FilePositionTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/lexer/GuessContentTypeTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/lexer/escaping/EscapingTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/lexer/escaping/UriUtilTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/parser/ParseTreeNodeTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/parser/ParserBaseTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/parser/ParserContextTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/parser/html/DoctypeMakerTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/parser/html/NodesRenderTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/parser/html/NodesTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/parser/js/ExpressionTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/parser/js/IdentifierTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/parser/js/NumberLiteralTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/parser/js/ParserTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/parser/js/StringLiteralTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/parser/quasiliteral/ModuleFormatTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/parser/quasiliteral/QuasiBuilderTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/plugin/PipelineMakerTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/plugin/stages/OptimizeJavascriptStageTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/plugin/templates/LocalizedHtmlTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/precajole/StaticPrecajoleMapTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/render/CssMinimalPrinterTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/render/CssPrettyPrinterTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/render/JsMinimalPrinterTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/render/JsPrettyPrinterTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/render/TokenClassificationTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/reporting/BuildInfoTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/service/AbstractCajolingHandlerTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/service/ContentTypeCheckTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/util/AbbreviatorTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/util/CollectionsTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/util/JoinTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/util/NameTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/util/SafeIdentifierMakerTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
tests/com/google/caja/util/SparseBitSetTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
tests/com/google/caja/util/StringsTest.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
MikeSamuel
Eclipse complains about methods that could be static but aren't. JUnit test methods are entry ...
12 years, 8 months ago (2013-08-08 00:45:39 UTC) #1
MikeSamuel
This CL is formulaic and one line per-file so it may be easier to review ...
12 years, 8 months ago (2013-08-08 00:46:44 UTC) #2
felix8a
On 2013/08/08 00:46:44, MikeSamuel wrote: > This CL is formulaic and one line per-file so ...
12 years, 8 months ago (2013-08-08 00:52:00 UTC) #3
MikeSamuel
Eclipse complains about methods that could be static but aren't. JUnit test methods are entry ...
12 years, 8 months ago (2013-08-08 19:02:41 UTC) #4
MikeSamuel
On 2013/08/08 00:52:00, felix8a wrote: > On 2013/08/08 00:46:44, MikeSamuel wrote: > > This CL ...
12 years, 8 months ago (2013-08-08 19:03:27 UTC) #5
felix8a
12 years, 8 months ago (2013-08-08 19:08:05 UTC) #6
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b