Issue 12634045: Viewlet breakout

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12634045: Viewlet breakout

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by bcsaller

Modified:
10 years, 8 months ago

Reviewers:
mp+179245, jeff.pihach, gary.poster

Visibility:
Public.

Description

Viewlet breakout Viewlets all live in their own modules. DEFAULT_VIEWLETS is gone, we use the viewlets namespace to hold things now and the viewlet list to select which belong to which inspector. https://code.launchpad.net/~bcsaller/juju-gui/viewlet-breakout/+merge/179245 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Viewlet breakout #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+606 lines, -410 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/modules-debug.js	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	app/views/databinding.js	View	1	3 chunks	+45 lines, -25 lines	0 comments	Download
M	app/views/inspector.js	View		5 chunks	+12 lines, -385 lines	0 comments	Download
A	app/views/viewlets/service-config.js	View		1 chunk	+84 lines, -0 lines	0 comments	Download
A	app/views/viewlets/service-constraints.js	View		1 chunk	+79 lines, -0 lines	0 comments	Download
A	app/views/viewlets/service-ghost.js	View		1 chunk	+77 lines, -0 lines	0 comments	Download
A	app/views/viewlets/service-overview.js	View		1 chunk	+291 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jeff.pihach

LGTM Thanks for the cleanup https://codereview.appspot.com/12634045/diff/1/app/views/databinding.js File app/views/databinding.js (right): https://codereview.appspot.com/12634045/diff/1/app/views/databinding.js#newcode34 app/views/databinding.js:34: slice = [].slice; does ...

10 years, 8 months ago (2013-08-08 17:55:47 UTC) #2

bcsaller

10 years, 8 months ago (2013-08-08 19:03:21 UTC) #4

*** Submitted:

Viewlet breakout

Viewlets all live in their own modules. DEFAULT_VIEWLETS is gone, we use
the viewlets namespace to hold things now and the viewlet list to select which
belong to which inspector.

R=jeff.pihach, gary.poster
CC=
https://codereview.appspot.com/12634045

Expand All Messages | Collapse All Messages